New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
status_server: add glibc, pthread, libgcc to the blocklist (#11205) #11474
status_server: add glibc, pthread, libgcc to the blocklist (#11205) #11474
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
close tikv#11108 Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
78e6866
to
7ee6e24
Compare
/merge |
@zhouqiang-cl: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 7ee6e24
|
/merge |
@sticnarf: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@YangKeao: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
… (tikv#11474) close tikv#11108 Signed-off-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Signed-off-by: Yilin Chen <sticnarf@gmail.com>
close #11108
Signed-off-by: YangKeao yangkeao@chunibyo.icu
What problem does this PR solve?
close #11108
Problem Summary:
If the
pprof-rs
sample arrives and the current program is fetching a backtrace, the program will panic. The reason is that there is a lock inside thedl_iterate_phdr
, which is called while unwinding the backtrace.A more detailed description about this problem can be found in tikv/pprof-rs#85 (comment) . In tikv, when an
Error
is generated, it's likely to get a backtrace and cause this problem.After adding these libraries to the blocklist, it will also be able to turn on the heap profiling and
pprof-rs
cpu profiling at the same time, but I haven't modified (and tested) it yet.What is changed and how it works?
What's Changed:
Skip all samples inside the
glibc
,pthread
andlibgcc
.Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tidb-ansible
:Check List
Side effects
The sample in the
libc
,libgcc
andpthread
will not be collected in the profiling result.Release note