-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raftstore: skip deleting snapshot files in peer pending_remove is true (#11782) #11905
raftstore: skip deleting snapshot files in peer pending_remove is true (#11782) #11905
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@tonyxuqqi you're already a collaborator in bot's repo. |
@BusyJay @5kbpers @tonyxuqqi |
@5kbpers @BusyJay @tonyxuqqi, ping~ |
@tonyxuqqi @BusyJay |
…31f1a392ba Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
/merge |
@BusyJay: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 4e084ad
|
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
cherry-pick #11782 to release-5.4
You can switch your code base to this Pull Request by using git-extras:
# In tikv repo: git pr https://github.com/tikv/tikv/pull/11905
After apply modifications, you can push your change to this PR via:
skip deleting snapshot files in peer pending_remove is true and the snapshot is being applied and canceled -- close #11746
This is to avoid the potential panic when the snapshot files are deleted, but the peer's status (Tombstone) is not persisted in disk due to tikv crash.
Signed-off-by: tonyxuqqi tonyxuqi@outlook.com
What is changed and how it works?
Close #11746
What's Changed:
Skip deleting snapshot files in peer.rs when the snapshot is being applied and just canceled and the peer is pending removal.
Related changes
Check List
Tests
Side effects
Release note