raftstore: skip deleting snapshot files in peer pending_remove is true (#11782)

[ti-srebot]

cherry-pick #11782 to release-5.3
You can switch your code base to this Pull Request by using git-extras:

# In tikv repo:
git pr https://github.com/tikv/tikv/pull/11908

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tikv.git pr/11908:release-5.3-8c31f1a392ba

---

skip deleting snapshot files in peer pending_remove is true and the snapshot is being applied and canceled -- close #11746

This is to avoid the potential panic when the snapshot files are deleted, but the peer's status (Tombstone) is not persisted in disk due to tikv crash.

Signed-off-by: tonyxuqqi tonyxuqi@outlook.com

What is changed and how it works?

Close #11746

What's Changed:
Skip deleting snapshot files in peer.rs when the snapshot is being applied and just canceled and the peer is pending removal.

Related changes

Check List

Tests

• Integration test

Side effects

Release note

Fix a potential panic (#11746) when snapshot files have been deleted but the peer's status is still Applying.

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• longfangsong
• youjiali1995

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[ti-srebot]

/run-all-tests

[ti-srebot]

@tonyxuqqi you're already a collaborator in bot's repo.

[longfangsong]

/test

[youjiali1995]

/merge

[ti-chi-bot]

@youjiali1995: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: bdf879d

[ti-chi-bot]

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.