Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log-backup: Added metrics for log backup #12516

Merged
merged 15 commits into from May 17, 2022
Merged

log-backup: Added metrics for log backup #12516

merged 15 commits into from May 17, 2022

Conversation

YuJuncen
Copy link
Contributor

@YuJuncen YuJuncen commented May 15, 2022 •
edited

What is changed and how it works?

Issue Number: Close #12534

(NOTE: this is based on #12511)

What's Changed:

Added the "Log Backup" row for tikv_details.

image

image

image

Added metrics for log backup.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    (It looks good.)
  • No code

Release note 

None

YuJuncen and others added 9 commits May 13, 2022 19:23
@YuJuncen
make test more stable && handle epoch not match
647810f 
Signed-off-by: Yu Juncen <yujuncen@pingcap.com>
@YuJuncen
add delay when start
ef44a4d 
Signed-off-by: Yu Juncen <yujuncen@pingcap.com>
@YuJuncen
Merge branch 'master' of https://github.com/tikv/tikv into fix-test
3fec0d7 
Signed-off-by: Yu Juncen <yujuncen@pingcap.com>
@YuJuncen
make clippy happy
b746aa1 
Signed-off-by: Yu Juncen <yujuncen@pingcap.com>
@YuJuncen
check observer version when accepting new events.
3faeeb2 
For log backup, it is ok to repeat data, but when lock repeated when observe changing, it may make lock failed to be unlocked.

Signed-off-by: Yu Juncen <yujuncen@pingcap.com>
@YuJuncen
Merge branch 'master' into fix-test
9bc5605
@YuJuncen
address comments
a9d2bfa 
Signed-off-by: Yu Juncen <yujuncen@pingcap.com>
@YuJuncen
add some metrics
e11eb3d 
- Task Status
- Internal Task (Actor Messages) Handling time

Signed-off-by: Yu Juncen <yujuncen@pingcap.com>
@YuJuncen
tweaking metrics
ac31fb4 
Signed-off-by: Yu Juncen <yujuncen@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 15, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@YuJuncen YuJuncen marked this pull request as draft May 15, 2022 06:04
@YuJuncen
fix scan pool name
09edd39 
Signed-off-by: Yu Juncen <yujuncen@pingcap.com>
@YuJuncen
Copy link
Contributor Author

/component backup-restore

@ti-chi-bot ti-chi-bot added the component/backup-restore Component: backup, import, external_storage label May 16, 2022
@YuJuncen
Copy link
Contributor Author

/sig migrate

@YuJuncen YuJuncen marked this pull request as ready for review May 16, 2022 09:39
3pointer
3pointer approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Status: PR - There is already 1 approval label May 17, 2022
@ti-chi-bot ti-chi-bot removed the status/LGT1 Status: PR - There is already 1 approval label May 17, 2022
@ti-chi-bot ti-chi-bot added the status/LGT2 Status: PR - There are already 2 approvals label May 17, 2022
@3pointer
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@3pointer: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@3pointer: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@overvenus: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: fd1320a

@ti-chi-bot ti-chi-bot added the status/can-merge Status: Can merge to base branch label May 17, 2022
@kennytm
Copy link
Contributor

kennytm commented May 17, 2022

/test

@ti-chi-bot
Copy link
Member

@YuJuncen: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 5d14f76 into tikv:master May 17, 2022
fengou1 pushed a commit to fengou1/tikv that referenced this pull request May 26, 2022
@YuJuncen @ti-chi-bot @fengou1
log-backup: Added metrics for log backup (tikv#12516)
cf26661 
ref tikv#12511, close tikv#12534

Added metrics for log backup.

Signed-off-by: Yu Juncen <yujuncen@pingcap.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overvenus overvenus overvenus approved these changes

@3pointer 3pointer 3pointer approved these changes

Assignees
No one assigned
Labels
component/backup-restore Component: backup, import, external_storage contribution Type: PR - From contributors release-note-none sig/migrate size/XXL status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

log-backup: add metrics for log backup
5 participants
@YuJuncen @ti-chi-bot @3pointer @overvenus @kennytm