Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

file_system: update fs2 fork to use posix_fallocate #12544

Merged
merged 2 commits into from May 17, 2022
Merged

file_system: update fs2 fork to use posix_fallocate #12544

merged 2 commits into from May 17, 2022

Conversation

tabokie
Copy link
Member

@tabokie tabokie commented May 17, 2022 •
edited

Signed-off-by: tabokie xy.tao@outlook.com

What is changed and how it works?

Issue Number: Close #12543

What's Changed:

fallocate is not as portable as posix_fallocate. The change is at tabokie/fs2-rs@cd50376.

Use `posix_fallocate` for space reservation.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Release note 

Use `posix_fallocate` for space reservation.

@tabokie
update fs2 fork to use posix_fallocate
dd187e2 
Signed-off-by: tabokie <xy.tao@outlook.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 17, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Connor1996
  • hunterlxt

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@tabokie tabokie changed the title update fs2 fork to use posix_fallocate file_system: update fs2 fork to use posix_fallocate May 17, 2022
hunterlxt
hunterlxt approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@hunterlxt hunterlxt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Status: PR - There is already 1 approval label May 17, 2022
Connor1996
Connor1996 approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels May 17, 2022
@tabokie
Copy link
Member Author

tabokie commented May 17, 2022

/merge

@ti-chi-bot
Copy link
Member

@tabokie: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 74a9f8f

@ti-chi-bot ti-chi-bot added the status/can-merge Status: Can merge to base branch label May 17, 2022
@ti-chi-bot ti-chi-bot merged commit 90c024a into tikv:master May 17, 2022
ti-srebot pushed a commit to ti-srebot/tikv that referenced this pull request May 17, 2022
@tabokie @ti-srebot
cherry pick tikv#12544 to release-5.4
3da6368 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request May 17, 2022
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #12553

ti-srebot pushed a commit to ti-srebot/tikv that referenced this pull request May 17, 2022
@tabokie @ti-srebot
cherry pick tikv#12544 to release-6.0
c619a2a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request May 17, 2022
Closed
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #12554

@tabokie tabokie deleted the fix-fallocate branch May 23, 2022 06:15
fengou1 pushed a commit to fengou1/tikv that referenced this pull request May 26, 2022
@tabokie @fengou1
file_system: update fs2 fork to use posix_fallocate (tikv#12544)
fff08e9 
close tikv#12543

Use `posix_fallocate` for space reservation.

Signed-off-by: tabokie <xy.tao@outlook.com>
@Anutrix Anutrix mentioned this pull request May 28, 2022
Open
ti-chi-bot pushed a commit that referenced this pull request Jun 21, 2022
@ti-srebot @tabokie
file_system: update fs2 fork to use posix_fallocate (#12544) (#12553)
50d6032 
close #12543, ref #12544

Use `posix_fallocate` for space reservation.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Xinye Tao <xy.tao@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Connor1996 Connor1996 Connor1996 approved these changes

@hunterlxt hunterlxt hunterlxt approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 needs-cherry-pick-release-6.0 release-note size/XS status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

space reserve fails on aufs
5 participants
@tabokie @ti-chi-bot @ti-srebot @Connor1996 @hunterlxt