Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rocksdb: update version to fix ldb print error #12547

Merged
merged 5 commits into from May 18, 2022
Merged

rocksdb: update version to fix ldb print error #12547

merged 5 commits into from May 18, 2022

Conversation

hunterlxt
Copy link
Member

Signed-off-by: Xintao hunterlxt@live.com

What is changed and how it works?

Issue Number: Close #12438

What's Changed:

rocksdb: update version to fix ldb print error

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note 

None

@hunterlxt
update rocksdb
ad2929f 
Signed-off-by: Xintao <hunterlxt@live.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 17, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Connor1996
  • tabokie

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@hunterlxt
Copy link
Member Author

Close to code freeze window, it looks like there is no new PRs to be merged in rust-rocksdb, so I create this PR to update

@hunterlxt hunterlxt added type/bugfix Type: PR - Fix a bug sig/engine SIG: Engine labels May 17, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Status: PR - There is already 1 approval label May 18, 2022
Connor1996
Connor1996 approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels May 18, 2022
@tabokie
Copy link
Member

tabokie commented May 18, 2022

/merge

@ti-chi-bot
Copy link
Member

@tabokie: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 237e193

@ti-chi-bot ti-chi-bot added the status/can-merge Status: Can merge to base branch label May 18, 2022
@ti-chi-bot ti-chi-bot merged commit 3dfef05 into tikv:master May 18, 2022
ti-srebot pushed a commit to ti-srebot/tikv that referenced this pull request May 18, 2022
@hunterlxt @ti-srebot
cherry pick tikv#12547 to release-6.0
faac6a1 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request May 18, 2022
Closed
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #12572

@hunterlxt hunterlxt deleted the xt/update-rocksdb branch May 19, 2022 02:36
fengou1 pushed a commit to fengou1/tikv that referenced this pull request May 26, 2022
@hunterlxt @tabokie
@ti-chi-bot @fengou1
rocksdb: update version to fix ldb print error (tikv#12547)
69eb1fe 
close tikv#12438

rocksdb: update version to fix ldb print error

Signed-off-by: Xintao <hunterlxt@live.com>

Co-authored-by: Xinye Tao <xy.tao@outlook.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Connor1996 Connor1996 Connor1996 approved these changes

@tabokie tabokie tabokie approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.0 release-note-none sig/engine SIG: Engine size/XS status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals type/bugfix Type: PR - Fix a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tikv-ctl ldb subcommand can't print right info
5 participants
@hunterlxt @ti-chi-bot @tabokie @ti-srebot @Connor1996