raftstore: remove ts for bucket keys #12551
Conversation
Signed-off-by: qi.xu <tonxuqi@outlook.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
| .map(|k| ::keys::origin_key(&k).to_vec()) | ||
| .collect(), | ||
| size: region_size, | ||
| .map(|k| strip_timestamp_if_exists(::keys::origin_key(&k).to_vec())) |
There was a problem hiding this comment.
| .map(|k| strip_timestamp_if_exists(::keys::origin_key(&k).to_vec())) | |
| .map(|k| strip_timestamp_if_exists(::keys::origin_key(&k).to_vec())).dedup() |
There was a problem hiding this comment.
你确定这个能编译吗？你上面dedup()的对象不是Vec<Vec>吧。
…to bucket_key_fix
Signed-off-by: qi.xu <tonxuqi@outlook.com>
Signed-off-by: qi.xu <tonxuqi@outlook.com>
Probably not. There's no pre_propose like hook for buckets. |
Signed-off-by: qi.xu <tonxuqi@outlook.com>
Signed-off-by: qi.xu <tonxuqi@outlook.com>
ti-chi-bot
added
needs-cherry-pick-release-6.0
and removed
do-not-merge/needs-triage-completed
labels
|
/remove-label needs-cherry-pick-6.0 |
|
/assign @5kbpers |
Signed-off-by: qi.xu <tonxuqi@outlook.com>
| None | ||
| } | ||
| }) | ||
| .coalesce(|prev, curr| { |
There was a problem hiding this comment.
This is almost the same as split check, why not reuse the code?
There was a problem hiding this comment.
As discussed, the parameter for is_valid_split_key is different--here it's per bucket range, not per region range.
| } | ||
| }) | ||
| .collect::<Vec<_>>(); | ||
| bucket.keys = adjusted_keys; |
There was a problem hiding this comment.
What if the key is beyond the region range?
There was a problem hiding this comment.
Theoretically it should not happen because bucket range is always within region range. But I can add an assert here.
Signed-off-by: qi.xu <tonxuqi@outlook.com>
…to bucket_key_fix
Signed-off-by: qi.xu <tonxuqi@outlook.com>
|
/remove-label needs-cherry-pick-6.0 |
ti-chi-bot
added
status/LGT2
Signed-off-by: qi.xu <tonxuqi@outlook.com>
|
/re-test |
|
/test |
|
/remove-label need-cherry-pick-6.0 |
|
@tonyxuqqi: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/remove-label needs-cherry-pick-6.0 |
|
/retest |
|
/test |
1 similar comment
|
/test |
|
/merge |
|
@tonyxuqqi: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
@tonyxuqqi: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/merge |
|
@5kbpers: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: be9dc07
|
close tikv#12549 remove ts from bucket keys Signed-off-by: qi.xu <tonxuqi@outlook.com> Co-authored-by: qi.xu <tonxuqi@outlook.com>
Signed-off-by: qi.xu tonxuqi@outlook.com
What is changed and how it works?
Issue Number: Close #12549
What's Changed:
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Release note