Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raftstore: enable waterfall panel by default #12559

Merged
merged 6 commits into from May 18, 2022
Merged

raftstore: enable waterfall panel by default #12559

merged 6 commits into from May 18, 2022

Conversation

ethercflow
Copy link
Member

@ethercflow ethercflow commented May 17, 2022 •
edited

Signed-off-by: Wenbo Zhang ethercflow@gmail.com

What is changed and how it works?

Issue Number: Close #12560

What's Changed:

raftstore: enable waterfall metrics by default

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • No code

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM

Release note 

raftstore: enable waterfall panel by default

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 17, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv
  • innerr

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ethercflow
raftstore: enable waterfall panel by default (tikv#12560)
a55ab7b 
close tikv#12560

Signed-off-by: Wenbo Zhang <ethercflow@gmail.com>
@ethercflow ethercflow changed the title raftstore: enable waterfall metrics by default raftstore: enable waterfall panal by default May 17, 2022
@ethercflow ethercflow changed the title raftstore: enable waterfall panal by default raftstore: enable waterfall panel by default May 17, 2022
innerr
innerr approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@innerr innerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Status: PR - There is already 1 approval label May 17, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels May 17, 2022
@innerr
Copy link
Contributor

innerr commented May 18, 2022

/merge

@ti-chi-bot
Copy link
Member

@innerr: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a55ab7b

@ti-chi-bot ti-chi-bot added the status/can-merge Status: Can merge to base branch label May 18, 2022
@ethercflow
Copy link
Member Author

/run-all-tests

@ethercflow
Copy link
Member Author

/test

1 similar comment
@ethercflow
Copy link
Member Author

/test

@ti-chi-bot
Copy link
Member

@ethercflow: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 32f2497 into tikv:master May 18, 2022
fengou1 pushed a commit to fengou1/tikv that referenced this pull request May 26, 2022
@ethercflow @ti-chi-bot @fengou1
raftstore: enable waterfall panel by default (tikv#12559)
220b3b0 
close tikv#12560

raftstore: enable waterfall metrics by default

Signed-off-by: Wenbo Zhang <ethercflow@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innerr innerr innerr approved these changes

@glorv glorv glorv approved these changes

Assignees
No one assigned
Labels
release-note size/XS status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Raftstore: enable waterfall panel by default
4 participants
@ethercflow @ti-chi-bot @innerr @glorv