*: avoid mutually exclusive features in pprof #12589
Conversation
Signed-off-by: mornyx <mornyx.z@gmail.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
do-not-merge/work-in-progress
do-not-merge/needs-triage-completed
contribution
|
/cc @sticnarf PTAL, thanks. Avoiding the mutex feature can avoid compilation errors in many scenarios. |
Signed-off-by: mornyx <mornyx.z@gmail.com>
ti-chi-bot
added
status/LGT2
|
/merge |
|
@zhongzc: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 1d4ad34
|
|
/run-test |
6 similar comments
|
/run-test |
|
/run-test |
|
/run-test |
|
/run-test |
|
/run-test |
|
/run-test |
|
/run-test |
|
/run-test |
|
@mornyx: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: mornyx <mornyx.z@gmail.com>
|
/merge |
|
@zhongzc: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 99e0e44
|
|
/run-test |
1 similar comment
|
/run-test |
Signed-off-by: mornyx mornyx.z@gmail.com
What's changed
Issue Number: Close #12590
In #12480, we have introduced two mutually exclusive features,
pprof-dwarfandpprof-fp. One of them must exist, otherwise a compilation error will occur. This introduces stricter requirements for feature usage in some modules.We need to relax them and keep only one
pprof-fp, anything else should automatically fallback to DWARF-based.Related PR
Release note