expr: fix tikv crash when conv empty string #12672

wshwsh12 · 2022-05-27T03:07:09Z

What is changed and how it works?

Issue Number: Close #12673

What's Changed:

Fix tikv crash when conv empty string

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
Need to cherry-pick to the release branch

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression
- Consumes more CPU
- Consumes more MEM
Breaking backward compatibility

Release note

Fix tikv crash when conv empty string

ti-chi-bot · 2022-05-27T03:07:10Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

sticnarf
youjiali1995

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

sticnarf · 2022-05-27T03:26:00Z

components/tidb_query_expr/src/impl_math.rs

+    if iter.peek().is_none() {
+        return None;
+    }
    let head = *iter.peek().unwrap();


It can be simplify it as:

Suggested change

if iter.peek().is_none() {

return None;

}

let head = *iter.peek().unwrap();

let head = *iter.peek()?;

Signed-off-by: wshwsh12 <793703860@qq.com>

wshwsh12 · 2022-05-27T05:27:15Z

/merge

ti-chi-bot · 2022-05-27T05:27:16Z

@wshwsh12: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-05-27T05:27:17Z

@wshwsh12: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

sticnarf · 2022-05-27T05:27:38Z

/merge

ti-chi-bot · 2022-05-27T05:27:38Z

@sticnarf: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-05-27T05:27:40Z

This pull request has been accepted and is ready to merge.

Commit hash: feefa06