Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: output warn log when some components config invalid #12767

Merged
merged 4 commits into from Jun 9, 2022

Conversation

3pointer
Copy link
Contributor

@3pointer 3pointer commented Jun 6, 2022

Signed-off-by: 3pointer luancheng@pingcap.com

What is changed and how it works?

Issue Number: Close #12771

What's Changed:
do not return error when validation failed. just change the config value to default instead.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

set backup.num-threads to 0
image

check the log.
image

check the config in log.
截屏2022-06-06 下午6 44 16

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

Fix the issue that tikv refused to start when the config of backup/import/cdc is invalid.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 6, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • overvenus
  • zhangjinpeng1987

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@3pointer
Copy link
Contributor Author

3pointer commented Jun 6, 2022

/rebuild

Signed-off-by: 3pointer <luancheng@pingcap.com>

change config by default

Signed-off-by: 3pointer <luancheng@pingcap.com>

format

Signed-off-by: 3pointer <luancheng@pingcap.com>

fix test

Signed-off-by: 3pointer <luancheng@pingcap.com>

make clippy

Signed-off-by: 3pointer <luancheng@pingcap.com>

fix test

Signed-off-by: 3pointer <luancheng@pingcap.com>

fix test

Signed-off-by: 3pointer <luancheng@pingcap.com>
Signed-off-by: 3pointer <luancheng@pingcap.com>
@ti-chi-bot ti-chi-bot added size/L and removed size/M labels Jun 6, 2022
@3pointer 3pointer marked this pull request as ready for review June 6, 2022 11:47
@ti-chi-bot ti-chi-bot added the status/LGT1 Status: PR - There is already 1 approval label Jun 7, 2022
Copy link
Member

@zhangjinpeng87 zhangjinpeng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Jun 8, 2022
Copy link
Contributor

@YuJuncen YuJuncen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Member

@YuJuncen: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@3pointer
Copy link
Contributor Author

3pointer commented Jun 9, 2022

/merge

@ti-chi-bot
Copy link
Member

@3pointer: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@3pointer: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@niubell
Copy link

niubell commented Jun 9, 2022

LGTM

@ti-chi-bot
Copy link
Member

@niubell: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@overvenus: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f5b7556

@ti-chi-bot ti-chi-bot added the status/can-merge Status: Can merge to base branch label Jun 9, 2022
@ti-chi-bot
Copy link
Member

@3pointer: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit fd7b4ad into tikv:master Jun 9, 2022
BornChanger pushed a commit to BornChanger/tikv that referenced this pull request Jun 10, 2022
close tikv#12771

Signed-off-by: 3pointer <luancheng@pingcap.com>

Co-authored-by: zhangjinpeng1987 <zhangjinpeng@pingcap.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
BornChanger pushed a commit to BornChanger/tikv that referenced this pull request Jun 10, 2022
close tikv#12771

Signed-off-by: 3pointer <luancheng@pingcap.com>

Co-authored-by: zhangjinpeng1987 <zhangjinpeng@pingcap.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/L status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config: auto set default configurations when configurations are not valid.
6 participants