Add check conditions before compaction filter in RawKV GC

[ystaticy]

What is changed and how it works?

Issue Number: Close #12935

What's Changed:

Add check conditions before compaction filter in RawKV GC

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)

Release note

Add check conditions before compaction filter in RawKV GC

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• cfzjywxk
• pingyu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[ystaticy]

/run-test

[ystaticy]

/run-test

[pingyu]

LGTM~

[cfzjywxk]

There're two check_need_gc methods in the gc_worker mod, as this check_need_gc would be used by both the txn and the raw KV, it's better to distinguish their names and usages in comments. Maybe the refactor could be done in later PRs.

[pingyu]

/hold

[pingyu]

Hold until v6.3.0 code freeze.

[pingyu]

/release

[sre-bot]

download tikv at http://fileserver.pingcap.net/download/builds/pingcap/tikv/pr/aa0d000411b5c4c05caa7d5e31c41c7b5acf4021/centos7/tikv-server.tar.gz

[pingyu]

/unhold

[pingyu]

/merge

[ti-chi-bot]

@pingyu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 647c8df

[guoxiangCN]

@ystaticy Hi~ Why did this PR add is_bottomost_level limitations, can you explain your original intention to me ？
the change:

if !raw_value.is_valid(self.current_ts) {
  self.raw_handle_delete();
}

to

if !raw_value.is_valid(self.current_ts) && self.is_bottommost_level {
  self.raw_handle_delete();
}