Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backup: Do not fill cache when backup rawkv #13022

Merged
merged 1 commit into from Jul 14, 2022
Merged

Backup: Do not fill cache when backup rawkv #13022

merged 1 commit into from Jul 14, 2022

Conversation

haojinming
Copy link
Contributor

Signed-off-by: haojinming jinming.hao@pingcap.com

What is changed and how it works?

Issue Number: Close #13020

What's Changed:

Do not fill cache when backup rawkv.

Related changes

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Side effects

Release note 

None

@haojinming
do not fill cache when backup rawkv
eeef557 
Signed-off-by: haojinming <jinming.hao@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 14, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • pingyu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

pingyu
pingyu approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@pingyu pingyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@ti-chi-bot ti-chi-bot added the status/LGT1 Status: PR - There is already 1 approval label Jul 14, 2022
@haojinming haojinming changed the title [RawKV BR] do not fill cache when backup rawkv Backup: Do not fill cache when backup rawkv Jul 14, 2022
3pointer
3pointer approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Jul 14, 2022
@pingyu
Copy link
Contributor

pingyu commented Jul 14, 2022

/merge

@ti-chi-bot
Copy link
Member

@pingyu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: eeef557

@ti-chi-bot ti-chi-bot added the status/can-merge Status: Can merge to base branch label Jul 14, 2022
@haojinming
Copy link
Contributor Author

/run-test

3 similar comments
@haojinming
Copy link
Contributor Author

/run-test

@haojinming
Copy link
Contributor Author

/run-test

@haojinming
Copy link
Contributor Author

/run-test

@ti-chi-bot ti-chi-bot merged commit 2358858 into tikv:master Jul 14, 2022
@ti-chi-bot ti-chi-bot added this to the Pool milestone Jul 14, 2022
ti-srebot pushed a commit to ti-srebot/tikv that referenced this pull request Jul 14, 2022
@haojinming @ti-srebot
cherry pick tikv#13022 to release-6.1
3d36cba 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 14, 2022
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-6.1 in PR #13025

@haojinming haojinming deleted the backup_raw_not_fill_cache branch July 14, 2022 10:25
ti-chi-bot added a commit that referenced this pull request Aug 22, 2022
@ti-srebot @haojinming @ti-chi-bot
Backup: Do not fill cache when backup rawkv (#13022) (#13025)
5fa4400 
close #13020, ref #13022

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: haojinming <jinming.hao@pingcap.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pingyu pingyu pingyu approved these changes

@3pointer 3pointer 3pointer approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.1 release-note-none size/XS status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Milestone
Pool
Development

Successfully merging this pull request may close these issues.

Should not fill cache when backup rawkv
5 participants
@haojinming @ti-chi-bot @pingyu @ti-srebot @3pointer