New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log-backup: fix early return #13288
log-backup: fix early return #13288
Conversation
Signed-off-by: Yu Juncen <yu745514916@live.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: Yu Juncen <yu745514916@live.com>
@@ -650,6 +665,45 @@ mod test { | |||
suite.cluster.shutdown(); | |||
} | |||
|
|||
/// This test tests whether we can handle some weird transactions and their |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How the "weird transactions" looks like? Could you add some comments?
Signed-off-by: Yu Juncen <yu745514916@live.com>
Signed-off-by: Yu Juncen <yu745514916@live.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
@overvenus: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 6b5a8c3
|
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-6.2 in PR #13291 |
close tikv#13281 Fixed a bug that may cause data loss in log backup. Signed-off-by: Yu Juncen <yu745514916@live.com> Signed-off-by: fengou1 <feng.ou@pingcap.com>
What is changed and how it works?
Issue Number: Close #13281
What's Changed:
This PR fixed a bug that may cause data loss with the satisfaction of these conditions:
write
CF.("adjacent" means, the initial scanning cannot get any commit entries interleaving them, the
DeltaScanner
emits a batch with 1,024Prewrite
s).split_txn
).Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
We have tested this with 1,000 tables in
sysbench
oltp_write_only
prepare phase.Release note