Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copr: use manually written json path parser #13317

Merged
merged 3 commits into from Sep 6, 2022
Merged

copr: use manually written json path parser #13317

merged 3 commits into from Sep 6, 2022

Conversation

YangKeao
Copy link
Member

Signed-off-by: YangKeao yangkeao@chunibyo.icu

What is changed and how it works?

Issue Number: Close #13316

What's Changed:

Use a manually written json path parser to parse the path.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

Fix the issue that the json path format is incompatible with MySQL

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 19, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • gengliqi
  • sticnarf

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@YangKeao
Copy link
Member Author

PTAL @xiongjiwei

xiongjiwei
xiongjiwei approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@xiongjiwei xiongjiwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

components/tidb_query_datatype/src/codec/mysql/json/path_expr.rs Outdated Show resolved Hide resolved
components/tidb_query_datatype/src/codec/mysql/json/path_expr.rs Show resolved Hide resolved
@ti-chi-bot
Copy link
Member

@xiongjiwei: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@xiongjiwei
Copy link
Contributor

lint failed

@xiongjiwei
Copy link
Contributor

/cc @wshwsh12 @gengliqi

@YangKeao YangKeao force-pushed the fix-path-expr-format branch 2 times, most recently from 3c088ef to dd10a3b Compare August 23, 2022 07:20
@YangKeao YangKeao mentioned this pull request Aug 24, 2022
Closed
34 tasks
@YangKeao
Copy link
Member Author

PTAL @wshwsh12 @gengliqi

@xiongjiwei
Copy link
Contributor

/cc @xhebox

@ti-chi-bot
Copy link
Member

@xiongjiwei: GitHub didn't allow me to request PR reviews from the following users: xhebox.

Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @xhebox

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@YangKeao
Copy link
Member Author

YangKeao commented Sep 1, 2022

@xhebox PTAL

@ti-chi-bot
Copy link
Member

@xhebox: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

sticnarf
sticnarf approved these changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@sticnarf sticnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Status: PR - There is already 1 approval label Sep 5, 2022
@sticnarf
Copy link
Contributor

sticnarf commented Sep 5, 2022

/merge

@ti-chi-bot
Copy link
Member

@sticnarf: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@sticnarf: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@YangKeao
Copy link
Member Author

YangKeao commented Sep 5, 2022

@wshwsh12 @gengliqi PTAL

gengliqi
gengliqi reviewed Sep 6, 2022
View reviewed changes
Copy link
Member

@gengliqi gengliqi left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment just for coding style: Use /// instead of // to document symbols(like functions or variables in struct/enum) and capitalize the first letter in comments. (Most codes I have seen obey this rule)
FYI: https://doc.rust-lang.org/book/ch14-02-publishing-to-crates-io.html#making-useful-documentation-comments

@YangKeao
use manually written json path parser
304f271 
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@YangKeao
add check for ascii control character
a5899c7 
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@YangKeao
Copy link
Member Author

YangKeao commented Sep 6, 2022

One comment just for coding style: Use /// instead of // to document symbols(like functions or variables in struct/enum) and capitalize the first letter in comments. (Most codes I have seen obey this rule)

@gengliqi Good! Fixed ❤️

@YangKeao YangKeao requested review from gengliqi and removed request for wshwsh12 September 6, 2022 06:01
@ti-chi-bot ti-chi-bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Sep 6, 2022
@YangKeao
Copy link
Member Author

YangKeao commented Sep 6, 2022

@gengliqi Thanks for pointing out ❤️ . Fixed 🤦‍♂️

@YangKeao
add overflow error check
1cdc067 
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@gengliqi
Copy link
Member

gengliqi commented Sep 6, 2022

/merge

@ti-chi-bot
Copy link
Member

@gengliqi: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1cdc067

@ti-chi-bot ti-chi-bot added the status/can-merge Status: Can merge to base branch label Sep 6, 2022
@ti-chi-bot ti-chi-bot merged commit 5ae75c8 into tikv:master Sep 6, 2022
@ti-chi-bot ti-chi-bot added this to the Pool milestone Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

@sticnarf sticnarf sticnarf approved these changes

@xiongjiwei xiongjiwei xiongjiwei approved these changes

@gengliqi gengliqi gengliqi approved these changes

Assignees
No one assigned
Labels
release-note size/XXL status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Milestone
Pool
Development

Successfully merging this pull request may close these issues.

JSON path is is incompatible with MySQL
6 participants
@YangKeao @ti-chi-bot @xiongjiwei @sticnarf @gengliqi @xhebox