Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service: add the kv_flashback_to_version interface #13378

Merged
merged 5 commits into from Sep 2, 2022
Merged

service: add the kv_flashback_to_version interface #13378

merged 5 commits into from Sep 2, 2022

Conversation

JmPotato
Copy link
Member

Signed-off-by: JmPotato ghzpotato@gmail.com

What is changed and how it works?

Issue Number: ref #13303. Should merge pingcap/kvproto#971 before this PR being merged.

What's Changed:

Implement the `kv_flashback_to_version` interface.

Check List

Tests

  • Unit test
  • Integration test

Release note 

None.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 30, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AndreMouche
  • disksing

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@JmPotato JmPotato mentioned this pull request Aug 30, 2022
Closed
10 tasks
@JmPotato JmPotato marked this pull request as ready for review September 2, 2022 03:43
@JmPotato
Copy link
Member Author

JmPotato commented Sep 2, 2022

/cc @HuSharp @Connor1996

@ti-chi-bot
Copy link
Member

@JmPotato: GitHub didn't allow me to request PR reviews from the following users: HuSharp.

Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @HuSharp @Connor1996

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Connor1996
Connor1996 reviewed Sep 2, 2022
View reviewed changes
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, please add test

@JmPotato JmPotato marked this pull request as draft September 2, 2022 06:14
@JmPotato
Add the kv_flashback_to_version interface
a003915 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato
Add some test cases
1e9e63a 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato marked this pull request as ready for review September 2, 2022 06:38
@JmPotato
Add a scheduling blocking test
40ff93e 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato
Update the kvproto
6bd2405 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Connor1996
Connor1996 approved these changes Sep 2, 2022
View reviewed changes
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JmPotato
Make the clippy happy
657efd4 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Status: PR - There is already 1 approval label Sep 2, 2022
@disksing
Copy link
Contributor

disksing commented Sep 2, 2022

/merge

@ti-chi-bot
Copy link
Member

@disksing: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@disksing: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

AndreMouche
AndreMouche approved these changes Sep 2, 2022
View reviewed changes
Copy link
Member

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Sep 2, 2022
@AndreMouche
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@AndreMouche: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 657efd4

@ti-chi-bot ti-chi-bot added the status/can-merge Status: Can merge to base branch label Sep 2, 2022
@ti-chi-bot ti-chi-bot merged commit b8315ad into tikv:master Sep 2, 2022
@ti-chi-bot ti-chi-bot added this to the Pool milestone Sep 2, 2022
@JmPotato JmPotato deleted the async_flashback_interface branch September 2, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HuSharp HuSharp HuSharp left review comments

@AndreMouche AndreMouche AndreMouche approved these changes

@disksing disksing disksing approved these changes

@Connor1996 Connor1996 Connor1996 approved these changes

Assignees
No one assigned
Labels
release-note-none size/L status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Milestone
Pool
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@JmPotato @ti-chi-bot @disksing @AndreMouche @Connor1996 @HuSharp