Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copr: implement several mysql time related types json #13418

Merged
merged 2 commits into from Sep 15, 2022

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Sep 6, 2022

Signed-off-by: YangKeao yangkeao@chunibyo.icu

What is changed and how it works?

Issue Number: Close #13417

What's Changed:

Add support for json date/datetime/timestamp/time types.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

Fix the issue that TiKV doesn't distinguish the `DATETIME/DATE/TIMESTAMP/TIME` and `STRING` in json type.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 6, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • gengliqi
  • sticnarf

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@YangKeao
Copy link
Member Author

YangKeao commented Sep 7, 2022

@xiongjiwei PTAL

@YangKeao YangKeao force-pushed the fix-9988 branch 6 times, most recently from dcfdcb0 to bb1c67d Compare September 8, 2022 06:33
@YangKeao
Copy link
Member Author

YangKeao commented Sep 8, 2022

/cc @wshwsh12 @gengliqi @sticnarf

PTAL ❤️

@YangKeao
Copy link
Member Author

YangKeao commented Sep 8, 2022

/tests

2 similar comments
@YangKeao
Copy link
Member Author

YangKeao commented Sep 8, 2022

/tests

@YangKeao
Copy link
Member Author

YangKeao commented Sep 8, 2022

/tests

@ti-chi-bot
Copy link
Member

@xiongjiwei: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@YangKeao YangKeao requested review from sticnarf and removed request for wshwsh12 and gengliqi September 14, 2022 06:18
Copy link
Contributor

@sticnarf sticnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to also add test cases for comparison and unquote

@ti-chi-bot ti-chi-bot added the status/LGT1 Status: PR - There is already 1 approval label Sep 14, 2022
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@YangKeao
Copy link
Member Author

Better to also add test cases for comparison and unquote

Added 😃

@ti-chi-bot ti-chi-bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Sep 15, 2022
@gengliqi
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@gengliqi: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 437ac18

@ti-chi-bot ti-chi-bot added the status/can-merge Status: Can merge to base branch label Sep 15, 2022
@ti-chi-bot
Copy link
Member

@YangKeao: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit d762bd8 into tikv:master Sep 15, 2022
@ti-chi-bot ti-chi-bot added this to the Pool milestone Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/XXL status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support date/datetime/timestamp/time in JSON
5 participants