Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Separate TestPdClient from test_raftstore component #13453

Merged
merged 3 commits into from Sep 14, 2022

Conversation

haojinming
Copy link
Contributor

@haojinming haojinming commented Sep 13, 2022

Signed-off-by: haojinming jinming.hao@pingcap.com

What is changed and how it works?

Issue Number: Close #13452

What's Changed:

`TestPdClient` is in `test_raftstore` component, which may cause circular dependency. For example, `causal_ts` need `TestPdClient`  and `test_raftstore` depend on `causal_ts`. 
Separate `TestPdClient` from `test_raftstore` component to avoid circular dependency.

Related changes

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Side effects

Release note

None

Signed-off-by: haojinming <jinming.hao@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 13, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Connor1996
  • pingyu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: haojinming <jinming.hao@pingcap.com>
@haojinming
Copy link
Contributor Author

/cc @pingyu @zeminzhou PTAL~, thanks.

Copy link
Contributor

@zeminzhou zeminzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@ti-chi-bot
Copy link
Member

@zeminzhou: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM~

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

@pingyu pingyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@ti-chi-bot ti-chi-bot added the status/LGT1 Status: PR - There is already 1 approval label Sep 13, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Sep 14, 2022
@pingyu
Copy link
Contributor

pingyu commented Sep 14, 2022

/merge

@ti-chi-bot
Copy link
Member

@pingyu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 004b165

@ti-chi-bot ti-chi-bot added the status/can-merge Status: Can merge to base branch label Sep 14, 2022
@ti-chi-bot ti-chi-bot merged commit 2563311 into tikv:master Sep 14, 2022
@ti-chi-bot ti-chi-bot added this to the Pool milestone Sep 14, 2022
@haojinming haojinming deleted the test_pd_client branch September 14, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/L status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate TestPdClient from test_raftstore component
5 participants