Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

engine: update raft-engine #13464

Merged
merged 3 commits into from Sep 15, 2022
Merged

engine: update raft-engine #13464

merged 3 commits into from Sep 15, 2022

Conversation

tabokie
Copy link
Member

@tabokie tabokie commented Sep 14, 2022

Signed-off-by: tabokie xy.tao@outlook.com

What is changed and how it works?

Issue Number: Ref #11119

What's Changed:

Related changes

Check List

Tests

  • Unit test

Release note 

None

@tabokie
update raft-engine
196fdf4 
Signed-off-by: tabokie <xy.tao@outlook.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 14, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • BusyJay
  • Connor1996

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 labels Sep 14, 2022
@tabokie tabokie removed the needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 label Sep 14, 2022
@BusyJay
Copy link
Member

BusyJay commented Sep 14, 2022

Can you describe more what's included and why the adjustment?

@tabokie
Copy link
Member Author

tabokie commented Sep 14, 2022

It's just an update. Some trait is changed and some config is deprecated. You can read the release note for more details: https://github.com/tikv/raft-engine/releases/tag/0.3.0

BusyJay
BusyJay reviewed Sep 14, 2022
View reviewed changes
etc/config-template.toml
@@ -1047,12 +1047,6 @@
## If you set this configuration item to `0`, compression is disabled.
# batch-compression-threshold = "8KB"

## Specifies the maximum accumulative size of buffered writes. When this
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the new sync behavior?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no limit of buffered writes now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it cause too many large IO?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will if you write a lot with sync=false, but it shouldn't be a problem with tikv. Note that the IO of one write group will not be split in both the old and new version.

@ti-chi-bot ti-chi-bot added the status/LGT1 Status: PR - There is already 1 approval label Sep 15, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Sep 15, 2022
@tabokie
Copy link
Member Author

tabokie commented Sep 15, 2022

/merge

@ti-chi-bot
Copy link
Member

@tabokie: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0981aa9

@ti-chi-bot ti-chi-bot added the status/can-merge Status: Can merge to base branch label Sep 15, 2022
@ti-chi-bot ti-chi-bot merged commit bdfde51 into tikv:master Sep 15, 2022
@ti-chi-bot ti-chi-bot added this to the Pool milestone Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BusyJay BusyJay BusyJay approved these changes

@Connor1996 Connor1996 Connor1996 approved these changes

Assignees
No one assigned
Labels
release-note-none size/M status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Milestone
Pool
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tabokie @ti-chi-bot @BusyJay @Connor1996