multi-rocksdb: avoid mutex deadlock between open_tablet() and create_shared_db()

[BornChanger]

Signed-off-by: BornChanger dawn_catcher@126.com

What is changed and how it works?

Issue Number: Close #13463

What's Changed:

Avoid holding mutex to root_db when open_tablet() calling create_shared_db() since root db creation won't bring racing, otherwise, mutex deadlock occurs.

Related changes

• PR to update pingcap/docs/pingcap/docs-cn:
• Need to cherry-pick to the release branch

Check List

Tests

• Unit test

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• BusyJay
• tonyxuqqi

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[BornChanger]

cc /@BusyJay /@tonyxuqqi

[BornChanger]

cc @BusyJay @tonyxuqqi

[BusyJay]

Interesting. This is a pitfall in Rust exists for quite a long time. Perhaps we should have some lint.

[BornChanger]

/run-check-issue-triage-complete

[BornChanger]

/cc @tonyxuqqi

[ti-chi-bot]

@SpadeA-Tang: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[BusyJay]

/merge

[ti-chi-bot]

@BusyJay: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: cc96f97

[ti-chi-bot]

@BornChanger: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.