readpool: update yatp and add new metrics for unified-read-pool

[glorv]

Signed-off-by: glorv glorvs@163.com

What is changed and how it works?

Issue Number: ref #13313

What's Changed:

update yatp and add new metrics for unified-read-pool

Preview of the new metrics:

Benchmark result:

I use sysbench oltp_read_only(with --range_selects) and select_random_ranges to test the impact of unified-read-pool. The test is running by benchbot with xl cluster(8c48gb) and 200 threads.

The nightly commit is da4877567c0ff11a863d6e39923e8c9819064a57 and the PR's commit is a264b5a5fdd6cf48e17a97db11d9d0d840578041. Each case is running for 15 minutes.

case	commit	thread	tps	qps	avg lat	p99 lat	p999 lat
select_random_ranges	nightly	200	78902	78890	2.30	7.46	15.1
select_random_ranges	this PR	200	80035(+1.4%)	80023(+1.4%)	2.26	7.17	14.6
oltp_read_only	nightly	200	4355	69584	2.18	8.73	18.2
oltp_read_only	this PR	200	4350	69508	2.19	8.71	18.4

Related changes

• PR to update pingcap/docs/pingcap/docs-cn:
• Need to cherry-pick to the release branch

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression
  • Consumes more CPU
  • Consumes more MEM
• Breaking backward compatibility

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• BusyJay
• sticnarf

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[sticnarf]

Is there any data about the performance impact of the newly added metrics?

[glorv]

Is there any data about the performance impact of the newly added metrics?

@sticnarf I benchmark this with sysbench with --threads=200 --tables=32 --table_size=50000000 oltp_read_only --range_selects --time=1800:

	before	after
tps	80316.03	79614.97
avg lat	39.84	40.19
p99 lat	77.19	77.19
max lag	446.35	285.57

The preformance difference is less than 1%, so I think there is no observable performance regression after this change.

[glorv]

/release

[glorv]

@sticnarf @BusyJay I have updated the benchmark result in the PR description. The result shows the performance is slight better in select_random_ranges and no regression in oltp_read_only.

[sticnarf]

LGTM

[Connor1996]

/merge

[ti-chi-bot]

@Connor1996: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: c3b730f

[ti-chi-bot]

@glorv: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.