Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "tikv_util: introduce future channel (#13407)" #13507

Merged
merged 1 commit into from Sep 21, 2022

Conversation

tabokie
Copy link
Member

@tabokie tabokie commented Sep 21, 2022

This reverts commit 7382d4e.

Signed-off-by: tabokie xy.tao@outlook.com

What is changed and how it works?

Issue Number: Ref #13394

What's Changed:

#13407 causes 3%~7% regression to multiple workloads, including update_non_index, oltp_read_write, bank, [...].

Test runs:

  • Bank: { 6.3 } = [-10%] { 6.2 }; { 6.3 + patch } = [-3.0%] { 6.2 }
  • update_non_index: { 6.2 + 6.3 tikv } = [-4%] { 6.2 }; { 6.2 + patch } = [+1%] { 6.2 }
  • update_non_index: { 6.3 } = [-7.5%] { 6.2 }; { 6.3 + patch } = [-2%] { 6.2 }
  • oltp_read_write: { 6.3 } = [-0.5%] { 6.2 }; { 6.3 + patch } = [+2%] { 6.2 }
  • TPC-C: { 6.3 } = [-6%] { 6.2 }; { 6.3 + patch } = [-4%] { 6.2 }

Related changes

Check List

Tests

  • Unit test

Release note

None

This reverts commit 7382d4e.

Signed-off-by: tabokie <xy.tao@outlook.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 21, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • BusyJay
  • sticnarf

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@tabokie
Copy link
Member Author

tabokie commented Sep 21, 2022

/run-build

@ti-chi-bot ti-chi-bot added the status/LGT1 Status: PR - There is already 1 approval label Sep 21, 2022
@BusyJay
Copy link
Member

BusyJay commented Sep 21, 2022

Interesting. I also did a benchmark and the difference was within 3%. #13407 (comment).

Copy link
Member

@BusyJay BusyJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as we 6.3 doesn't depend on the patch.

@ti-chi-bot ti-chi-bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Sep 21, 2022
@sticnarf
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@sticnarf: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5e46160

@ti-chi-bot ti-chi-bot added the status/can-merge Status: Can merge to base branch label Sep 21, 2022
@ti-chi-bot ti-chi-bot merged commit 2cdc26f into tikv:release-6.3 Sep 21, 2022
@tabokie tabokie deleted the 220921-revert-channel branch September 21, 2022 10:06
BusyJay pushed a commit to BusyJay/tikv that referenced this pull request Sep 26, 2022
sticnarf pushed a commit to sticnarf/tikv that referenced this pull request Sep 26, 2022
BusyJay added a commit to BusyJay/tikv that referenced this pull request Sep 28, 2022
…kv#13507)"

This reverts commit b219a82.

Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none size/XXL status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants