New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "tikv_util: introduce future channel (#13407)" #13507
Conversation
This reverts commit 7382d4e. Signed-off-by: tabokie <xy.tao@outlook.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-build |
Interesting. I also did a benchmark and the difference was within 3%. #13407 (comment). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as we 6.3 doesn't depend on the patch.
/merge |
@sticnarf: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 5e46160
|
ref tikv#13394, ref tikv#13407 Signed-off-by: tabokie <xy.tao@outlook.com>
ref tikv#13394, ref tikv#13407 Signed-off-by: tabokie <xy.tao@outlook.com>
This reverts commit 7382d4e.
Signed-off-by: tabokie xy.tao@outlook.com
What is changed and how it works?
Issue Number: Ref #13394
What's Changed:
#13407 causes 3%~7% regression to multiple workloads, including update_non_index, oltp_read_write, bank, [...].
Test runs:
Related changes
Check List
Tests
Release note