Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

channel: early break when fetch nothing #13516

Merged
merged 9 commits into from Oct 12, 2022
Merged

channel: early break when fetch nothing #13516

merged 9 commits into from Oct 12, 2022

Conversation

BusyJay
Copy link
Member

@BusyJay BusyJay commented Sep 21, 2022 •
edited

What is changed and how it works?

Issue Number: Close #13394

What's Changed:

Otherwise it will waste CPU on loop.

Check List

Tests

  • Unit test
  • Integration test

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 21, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Connor1996
  • sticnarf

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@BusyJay
Copy link
Member Author

BusyJay commented Sep 21, 2022

/release

@sre-bot
Copy link
Contributor

sre-bot commented Sep 21, 2022

download tikv at http://fileserver.pingcap.net/download/builds/pingcap/tikv/pr/4c2bab547671fa9fc3cf5bd33b021b83e5113516/centos7/tikv-server.tar.gz

@BusyJay
Copy link
Member Author

BusyJay commented Sep 22, 2022

/release

@sre-bot
Copy link
Contributor

sre-bot commented Sep 22, 2022

download tikv at http://fileserver.pingcap.net/download/builds/pingcap/tikv/pr/d418f60cbd4e1059908640f2597373d36f3189ac/centos7/tikv-server.tar.gz

@BusyJay
Copy link
Member Author

BusyJay commented Sep 26, 2022

/release

@sre-bot
Copy link
Contributor

sre-bot commented Sep 26, 2022

download tikv at http://fileserver.pingcap.net/download/builds/pingcap/tikv/pr/b219a823b994f68b5a54e7ef8a10d82b047b68ef/centos7/tikv-server.tar.gz

@BusyJay
Copy link
Member Author

BusyJay commented Sep 28, 2022

/release

@sre-bot
Copy link
Contributor

sre-bot commented Sep 28, 2022

download tikv at http://fileserver.pingcap.net/download/builds/pingcap/tikv/pr/f0d109466e525ea37797e5ab8a55545c44fe4732/centos7/tikv-server.tar.gz

@BusyJay
Copy link
Member Author

BusyJay commented Sep 29, 2022

/release

@sre-bot
Copy link
Contributor

sre-bot commented Sep 29, 2022

download tikv at http://fileserver.pingcap.net/download/builds/pingcap/tikv/pr/575c4e555927838f17f8f8614f2ada63516c0163/centos7/tikv-server.tar.gz

@ti-chi-bot ti-chi-bot added size/M and removed size/L labels Oct 7, 2022
@BusyJay
tikv_util: use box waker
3822e36 
Our perf test shows that box waker and period wake policy has better
performance than the current implementation.

Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-6.3 Type: Need cherry pick to release-6.3 and removed do-not-merge/needs-linked-issue labels Oct 7, 2022
@BusyJay BusyJay marked this pull request as ready for review October 7, 2022 08:03
@BusyJay BusyJay removed the needs-cherry-pick-release-6.3 Type: Need cherry pick to release-6.3 label Oct 7, 2022
@BusyJay
only break
1e5773c 
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@BusyJay
Copy link
Member Author

BusyJay commented Oct 11, 2022

/release

@sre-bot
Copy link
Contributor

sre-bot commented Oct 11, 2022

download tikv at http://fileserver.pingcap.net/download/builds/pingcap/tikv/pr/1e5773cc439e5035970c1481993bc494278dfd1f/centos7/tikv-server.tar.gz

@BusyJay BusyJay changed the title util: use box waker channel: early break when fetch nothing Oct 11, 2022
@BusyJay BusyJay removed the needs-cherry-pick-release-6.3 Type: Need cherry pick to release-6.3 label Oct 11, 2022
sticnarf
sticnarf approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@sticnarf sticnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Does the new channel implementation bring no regression now?

@ti-chi-bot ti-chi-bot added the status/LGT1 Status: PR - There is already 1 approval label Oct 12, 2022
@BusyJay
Copy link
Member Author

BusyJay commented Oct 12, 2022

Yes, and it actually performs slightly better in bank test.

Hash Test 0 Test 1 Test 2
1e5773c (This PR) 74051 69281 66032
b219a82 (Revert future channel) 67405 66515 64979

Connor1996
Connor1996 approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Oct 12, 2022
@BusyJay
Copy link
Member Author

BusyJay commented Oct 12, 2022

/merge

@ti-chi-bot
Copy link
Member

@BusyJay: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1e5773c

@ti-chi-bot ti-chi-bot added the status/can-merge Status: Can merge to base branch label Oct 12, 2022
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-6.3 Type: Need cherry pick to release-6.3 label Oct 12, 2022
@BusyJay BusyJay removed the needs-cherry-pick-release-6.3 Type: Need cherry pick to release-6.3 label Oct 12, 2022
@BusyJay
Copy link
Member Author

BusyJay commented Oct 12, 2022

/test

1 similar comment
@BusyJay
Copy link
Member Author

BusyJay commented Oct 12, 2022

/test

@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-6.3 Type: Need cherry pick to release-6.3 label Oct 12, 2022
@ti-chi-bot ti-chi-bot merged commit 066a422 into tikv:master Oct 12, 2022
@ti-chi-bot ti-chi-bot added this to the Pool milestone Oct 12, 2022
@ti-srebot ti-srebot mentioned this pull request Oct 12, 2022
Closed
ti-srebot pushed a commit to ti-srebot/tikv that referenced this pull request Oct 12, 2022
@ti-srebot
cherry pick tikv#13516 to release-6.3
be52510 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-6.3 in PR #13590

@BusyJay BusyJay deleted the reimplement-wake branch October 12, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Connor1996 Connor1996 Connor1996 approved these changes

@sticnarf sticnarf sticnarf approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.3 Type: Need cherry pick to release-6.3 release-note-none size/XS status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Milestone
Pool
Development

Successfully merging this pull request may close these issues.

commit 68f99 causing sysbench oltp_read_write performance degradation 4.4%- 5.3%
6 participants
@BusyJay @ti-chi-bot @sre-bot @sticnarf @Connor1996 @ti-srebot