rawkv: Fix unstable test-region-merge #13580
Conversation
Signed-off-by: pingyu <yuping@pingcap.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: pingyu <yuping@pingcap.com>
|
/run-test |
pingyu
changed the title
|
@pingyu: GitHub didn't allow me to request PR reviews from the following users: zeminzhou. Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
PTAL, thanks~ |
|
/run-test |
pingyu
force-pushed
the
fix-test-region-merge
branch
from
d026efa
to
d8270d2
Compare
Signed-off-by: pingyu <yuping@pingcap.com>
pingyu
force-pushed
the
fix-test-region-merge
branch
from
d8270d2
to
f172881
Compare
| @@ -164,8 +164,8 @@ fn test_leader_transfer() { | |||
| assert_eq!(suite.must_raw_get(key1), Some(b"v4".to_vec())); | |||
| } | |||
|
|
|||
| // Disable CausalObserver::flush_timestamp to produce causality issue. | |||
| fail::cfg(FP_CAUSAL_TS_PROVIDER_FLUSH, "return").unwrap(); | |||
| // Make causal_ts_provider.async_flush() & handle_update_max_timestamp fail. | |||
There was a problem hiding this comment.
Could you explain why failpoint FP_GET_TSO cant make causal_ts_provider.async_flush() & handle_update_max_timestamp fail ?
There was a problem hiding this comment.
The critical path of causal_ts_provider.async_flush() is getting a batch of TSOs from PD and renew the TSO cache. So the error of get_tso must make causal_ts_provider.async_flush() fail.
Please refer to BatchTsoProvider::renew_tso_batch_impl().
And handle_update_max_timestamp() invokes causal_ts_provider.async_flus() here (when storage.api-version = 2). So handle_update_max_timestamp() will also fail (and keep retrying until succeed).
|
@zeminzhou: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
ti-chi-bot
added
status/LGT2
|
/merge |
|
@pingyu: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: f172881
|
Signed-off-by: pingyu yuping@pingcap.com
What is changed and how it works?
Issue Number: Close #13582
What's Changed:
The failure of
test_rawkv::test_region_mergeshould be caused by the fail pointcausal_ts_provider_flush, which makehandle_update_max_timestampin a busy loop and exhaust the pd worker of raftstore.Related changes
pingcap/docs/pingcap/docs-cn:No.
No.
Check List
Tests
Side effects
Release note