Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect Raft Engine Disk Usage #13633

Merged
merged 26 commits into from Nov 16, 2022
Merged

Protect Raft Engine Disk Usage #13633

merged 26 commits into from Nov 16, 2022

Conversation

jiayang-zheng
Copy link
Contributor

@jiayang-zheng jiayang-zheng commented Oct 18, 2022 •
edited

Signed-off-by: Jarvis Zheng jiayang@hust.edu.cn

What is changed and how it works?

Issue Number: Close #13642

What's Changed:

Stop write flow if raft disk is full.

Related changes

tikv/raft-engine#276

Check List

Tests

Side effects
None.

Release note 

Stop write flow if raft disk is full.

@jiayang-zheng
Add raft-engine-almost-full-percent
e8bd3eb 
Signed-off-by: Jarvis Zheng <jiayang@hust.edu.cn>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 18, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tabokie
  • tonyxuqqi

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added size/M and removed size/S labels Oct 18, 2022
@jiayang-zheng
Merge master
6700afe 
Signed-off-by: Jarvis Zheng <jiayang@hust.edu.cn>
@jiayang-zheng
Add get_engine_path interface for RaftEngine trait
5055222 
Signed-off-by: Jarvis Zheng <jiayang@hust.edu.cn>
@jiayang-zheng
Adjust disk stat logic for raft disk.
5aaca2e 
Signed-off-by: Jarvis Zheng <jiayang@hust.edu.cn>
@ti-chi-bot ti-chi-bot added size/L and removed size/M labels Oct 19, 2022
@jiayang-zheng jiayang-zheng mentioned this pull request Oct 20, 2022
Merged
tonyxuqqi
tonyxuqqi reviewed Oct 20, 2022
View reviewed changes
Copy link
Contributor

@tonyxuqqi tonyxuqqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
It will be better to add a unit test case for path_in_diff_mount_point and an integration test for raft log full scenario.

@jiayang-zheng
Add UT for path_in_diff_mount_point function.
bbb15ae 
Signed-off-by: Jarvis Zheng <jiayang@hust.edu.cn>
@jiayang-zheng jiayang-zheng changed the title [WIP] Protect Raft Engine Disk Usage Protect Raft Engine Disk Usage Oct 21, 2022
@jiayang-zheng
Restore raft-engine dependency.
d1f109c 
Signed-off-by: Jarvis Zheng <jiayang@hust.edu.cn>
@jiayang-zheng
Copy link
Contributor Author

/cc @tabokie

@jiayang-zheng
Copy link
Contributor Author

/cc @BusyJay

@ti-chi-bot ti-chi-bot added the status/LGT1 Status: PR - There is already 1 approval label Nov 9, 2022
@jiayang-zheng
Skip setting raft disk status if reserve_raft_space is set to zero.
a92e8d5 
Signed-off-by: Jarvis Zheng <jiayang@hust.edu.cn>
tabokie
tabokie reviewed Nov 10, 2022
View reviewed changes
etc/config-template.toml Outdated Show resolved Hide resolved
components/engine_panic/src/raft_engine.rs Show resolved Hide resolved
components/server/src/server.rs Show resolved Hide resolved
@jiayang-zheng @tabokie
Update indent for reserve-raft-space in etc/config-template.toml
3cb4070 
Co-authored-by: Xinye Tao <xy.tao@outlook.com>
Signed-off-by: Jarvis <jiayang@hust.edu.cn>
tabokie
tabokie reviewed Nov 10, 2022
View reviewed changes
components/engine_panic/src/raft_engine.rs Show resolved Hide resolved
components/server/src/server.rs Outdated Show resolved Hide resolved
components/server/src/server.rs Show resolved Hide resolved
components/server/src/server.rs Show resolved Hide resolved
@jiayang-zheng jiayang-zheng requested review from tabokie and JmPotato and removed request for tabokie and JmPotato November 15, 2022 06:05
@ti-chi-bot ti-chi-bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Nov 16, 2022
@jiayang-zheng
Merge master
b6886e3 
Signed-off-by: Jarvis Zheng <jiayang@hust.edu.cn>
@tabokie
Copy link
Member

tabokie commented Nov 16, 2022

/merge

@ti-chi-bot
Copy link
Member

@tabokie: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b6886e3

@ti-chi-bot ti-chi-bot added the status/can-merge Status: Can merge to base branch label Nov 16, 2022
@ti-chi-bot ti-chi-bot merged commit 2704588 into tikv:master Nov 16, 2022
@ti-chi-bot ti-chi-bot added this to the Pool milestone Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JmPotato JmPotato JmPotato left review comments

@tonyxuqqi tonyxuqqi tonyxuqqi approved these changes

@tabokie tabokie tabokie approved these changes

Assignees
No one assigned
Labels
contribution Type: PR - From contributors release-note size/L status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Milestone
Pool
Development

Successfully merging this pull request may close these issues.

Stop write flow if raftdb/raft engine is full
5 participants
@jiayang-zheng @ti-chi-bot @tabokie @JmPotato @tonyxuqqi