Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdc: remove deprecated config #13762

Merged
merged 2 commits into from Nov 10, 2022

Conversation

haojinming
Copy link
Contributor

Signed-off-by: haojinming jinming.hao@pingcap.com

What is changed and how it works?

Issue Number: Close #13761

What's Changed:


raw-min-ts-outlier-threshold is marked as deprecated from v6.4. It should be removed from v6.5.
https://docs.pingcap.com/zh/tidb/dev/tikv-configuration-file#raw-min-ts-outlier-threshold-%E4%BB%8E-v620-%E7%89%88%E6%9C%AC%E5%BC%80%E5%A7%8B%E5%BC%95%E5%85%A5

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Side effects

Release note

None

Signed-off-by: haojinming <jinming.hao@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 9, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • overvenus
  • pingyu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@haojinming
Copy link
Contributor Author

@pingyu @overvenus PTAL~ thanks.

Copy link
Contributor

@pingyu pingyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@ti-chi-bot ti-chi-bot added the status/LGT1 Status: PR - There is already 1 approval label Nov 9, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Nov 10, 2022
@pingyu
Copy link
Contributor

pingyu commented Nov 10, 2022

/merge

@ti-chi-bot
Copy link
Member

@pingyu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ed8d552

@ti-chi-bot ti-chi-bot added the status/can-merge Status: Can merge to base branch label Nov 10, 2022
@ti-chi-bot ti-chi-bot merged commit e87d16d into tikv:master Nov 10, 2022
@ti-chi-bot ti-chi-bot added this to the Pool milestone Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/S status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cdc: Remove deprecated config
4 participants