Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: update crossbeam-channel to avoid spin at sending side #13807

Merged
merged 2 commits into from Nov 17, 2022

Conversation

sticnarf
Copy link
Contributor

@sticnarf sticnarf commented Nov 16, 2022

What is changed and how it works?

Issue Number: Close #13815

What's Changed:

According to https://github.com/crossbeam-rs/crossbeam/pull/835, spinning at the
sending side is probably a bad idea because of large critical section and it's
fixed in the recent version.

This commit updates crossbeam-channel. It will reduce CPU usage a bit and
improve performance.

Spinlock vs mutex is really tricky. Generally, using a mutex is never a bad idea but sometimes spinning improves performance. But in this case, our benchbot doesn't support spinning.

I did A-B-A (where A uses latest crossbeam-channel) tests, the one with latest crossbeam-channel wins consistently.

image

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release note

None

Signed-off-by: Yilin Chen <sticnarf@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 16, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • BusyJay
  • tabokie

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@sticnarf
Copy link
Contributor Author

/release

@ti-chi-bot ti-chi-bot added the status/LGT1 Status: PR - There is already 1 approval label Nov 17, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Nov 17, 2022
@sticnarf
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@sticnarf: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: de1acbb

@ti-chi-bot ti-chi-bot added the status/can-merge Status: Can merge to base branch label Nov 17, 2022
@ti-chi-bot
Copy link
Member

@sticnarf: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sticnarf
Copy link
Contributor Author

/test

2 similar comments
@sticnarf
Copy link
Contributor Author

/test

@sticnarf
Copy link
Contributor Author

/test

@ti-chi-bot ti-chi-bot merged commit 7dfb42e into tikv:master Nov 17, 2022
@ti-chi-bot ti-chi-bot added this to the Pool milestone Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/XS status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update crossbeam-channel to avoid spinning in waker
5 participants