Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async-io: make v2 a log batch #13935

Merged
merged 2 commits into from Dec 14, 2022

Conversation

BusyJay
Copy link
Member

@BusyJay BusyJay commented Dec 13, 2022

What is changed and how it works?

Issue Number: Ref #12842

What's Changed:

We now map states with apply index, so there is nothing to merge.
Use a log batch for better flexibility to introduce more extra writes.

Check List

Tests

  • Unit test
  • Integration test

Release note

None

We now map states with apply index, so there is nothing to merge. Use a log
batch for better flexibility to introduce more extra writes.

Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 13, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tabokie
  • tonyxuqqi

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Status: PR - There is already 1 approval label Dec 14, 2022
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@ti-chi-bot ti-chi-bot added size/XL and removed size/L labels Dec 14, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Dec 14, 2022
@BusyJay
Copy link
Member Author

BusyJay commented Dec 14, 2022

/merge

@ti-chi-bot
Copy link
Member

@BusyJay: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ff7d85d

@ti-chi-bot ti-chi-bot added the status/can-merge Status: Can merge to base branch label Dec 14, 2022
@ti-chi-bot ti-chi-bot merged commit cfdb31f into tikv:master Dec 14, 2022
@ti-chi-bot ti-chi-bot added this to the Pool milestone Dec 14, 2022
@BusyJay BusyJay deleted the make-extra-states-writebatch branch December 14, 2022 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/XL status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants