add commit/apply duration for raft store #13946
Conversation
Signed-off-by: bufferflies <1045931706@qq.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
|
@bufferflies: GitHub didn't allow me to request PR reviews from the following users: SpadeA-Tang. Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cc @SpadeA-Tang |
|
@bufferflies: GitHub didn't allow me to request PR reviews from the following users: SpadeA-Tang. Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: bufferflies <1045931706@qq.com>
| @@ -126,6 +128,7 @@ impl<EK: KvEngine, R: ApplyResReporter> ApplyFsm<EK, R> { | |||
| } | |||
| } | |||
| self.apply.flush(); | |||
| STORE_APPLY_LOG_HISTOGRAM.observe(duration_to_sec(received_time.saturating_elapsed())); | |||
There was a problem hiding this comment.
This is not accurate as the fsm may be reschedule where there is an await.
There was a problem hiding this comment.
From end-to-end perspective, I think it's the time the user request actually pays for the apply. So it's ok.
There was a problem hiding this comment.
No, it's not. It just the time apply finish a round of processing. Before the timer stops, user may have sent and received multiple round of req/resp.
There was a problem hiding this comment.
Got it, I will using water fall to replace removing this metrics in next pr.
ti-chi-bot
added
status/LGT2
Signed-off-by: bufferflies <1045931706@qq.com>
Signed-off-by: bufferflies <1045931706@qq.com>
Signed-off-by: bufferflies <1045931706@qq.com>
|
/merge |
|
@iosmanthus: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 8d6c5f7
|
Signed-off-by: bufferflies 1045931706@qq.com
What is changed and how it works?
Issue Number: Ref #12842
What's Changed:
Related changes
Check List
Tests
Apply duration
Apply wait duration
Side effects
Release note