Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support start with raftkv2 #13981

Merged
merged 7 commits into from Dec 23, 2022
Merged

*: support start with raftkv2 #13981

merged 7 commits into from Dec 23, 2022

Conversation

BusyJay
Copy link
Member

@BusyJay BusyJay commented Dec 22, 2022

What is changed and how it works?

Issue Number: Ref #12842

What's Changed:

This PR enables start raftkv2 by introducing a new module named server2.rs.
server2.rs is just copied and adjusted from server.rs. For now, I avoid
edit server.rs in place in case introducing bad problems. In the long term,
perhaps next month, I will merge server.rs with server2.rs.

To make review easier, I rename server.rs to server_rn.rs, and server2.rs to server.rs.
So github can display what's missing and changed in server2. I will revert the naming
before merging.

Not all functionality are supported, this is just a naive pure
KV system with transaction support.

Check List

Tests

  • Unit test
  • Integration test

Release note

None

Not all functionality are supported, this is just a naive pure KV system
with transaction support.

Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 22, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tabokie
  • tonyxuqqi

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
Copy link
Contributor

@tonyxuqqi tonyxuqqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the TODOs in the code for functions that are missing in v2 (such as backup, ebs snapshot recovery, etc). Thanks.

@ti-chi-bot ti-chi-bot added the status/LGT1 Status: PR - There is already 1 approval label Dec 22, 2022

let path = entry.path();
// Generated snapshots are just checkpoints, only counts received snapshots.
if !path.starts_with(SNAP_REV_PREFIX) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

path.file_name?

@ti-chi-bot ti-chi-bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Dec 23, 2022
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@BusyJay
Copy link
Member Author

BusyJay commented Dec 23, 2022

/merge

@ti-chi-bot
Copy link
Member

@BusyJay: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f168df2

@ti-chi-bot ti-chi-bot added the status/can-merge Status: Can merge to base branch label Dec 23, 2022
This reverts commit fcfb618.

Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@BusyJay
Copy link
Member Author

BusyJay commented Dec 23, 2022

/merge

@ti-chi-bot
Copy link
Member

@BusyJay: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot removed status/can-merge Status: Can merge to base branch labels Dec 23, 2022
@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bc8c068

@ti-chi-bot ti-chi-bot added the status/can-merge Status: Can merge to base branch label Dec 23, 2022
@ti-chi-bot
Copy link
Member

@BusyJay: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@ti-chi-bot ti-chi-bot removed the status/can-merge Status: Can merge to base branch label Dec 23, 2022
@BusyJay
Copy link
Member Author

BusyJay commented Dec 23, 2022

/merge

@ti-chi-bot
Copy link
Member

@BusyJay: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5e959f1

@ti-chi-bot ti-chi-bot added the status/can-merge Status: Can merge to base branch label Dec 23, 2022
@ti-chi-bot ti-chi-bot merged commit 90505f5 into tikv:master Dec 23, 2022
@ti-chi-bot ti-chi-bot added this to the Pool milestone Dec 23, 2022
@BusyJay BusyJay deleted the server2 branch December 29, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/XXL status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants