New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: support start with raftkv2 #13981
Conversation
Not all functionality are supported, this is just a naive pure KV system with transaction support. Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the TODOs in the code for functions that are missing in v2 (such as backup, ebs snapshot recovery, etc). Thanks.
|
||
let path = entry.path(); | ||
// Generated snapshots are just checkpoints, only counts received snapshots. | ||
if !path.starts_with(SNAP_REV_PREFIX) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
path.file_name?
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
/merge |
@BusyJay: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: f168df2
|
This reverts commit fcfb618. Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
/merge |
@BusyJay: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: bc8c068
|
@BusyJay: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
/merge |
@BusyJay: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 5e959f1
|
What is changed and how it works?
Issue Number: Ref #12842
What's Changed:
This PR enables start raftkv2 by introducing a new module named server2.rs.
server2.rs is just copied and adjusted from server.rs. For now, I avoid
edit server.rs in place in case introducing bad problems. In the long term,
perhaps next month, I will merge server.rs with server2.rs.
To make review easier, I rename server.rs to server_rn.rs, and server2.rs to server.rs.
So github can display what's missing and changed in server2. I will revert the naming
before merging.
Check List
Tests
Release note