Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: add priority scheduling for scheduler worker #14057

Merged
merged 6 commits into from Jan 17, 2023
Merged

storage: add priority scheduling for scheduler worker #14057

merged 6 commits into from Jan 17, 2023

Conversation

Connor1996
Copy link
Member

Signed-off-by: Connor1996 zbk602423539@gmail.com

What is changed and how it works?

Issue Number: Ref #13730

What's Changed:

Support priority-based scheduling for the scheduler worker pool.

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression
    • Consumes more CPU

Release note 

Support priority-based scheduling for the scheduler worker pool

@Connor1996
ref 13730 add priority scheduling for scheduler worker
b0250bb 
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@Connor1996
fix clippy
abf03f9 
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 16, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv
  • tabokie

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@Connor1996 Connor1996 marked this pull request as ready for review January 16, 2023 14:15
@Connor1996 Connor1996 requested a review from glorv January 16, 2023 14:21
@Connor1996
add comment
a4eb799 
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
glorv
glorv reviewed Jan 17, 2023
View reviewed changes
components/tikv_util/src/yatp_pool/mod.rs Outdated Show resolved Hide resolved
components/resource_control/src/resource_group.rs Outdated Show resolved Hide resolved
components/resource_control/src/resource_group.rs Outdated Show resolved Hide resolved
@nolouch nolouch mentioned this pull request Jan 17, 2023
Closed
41 tasks
@Connor1996
address comment
caf25a7 
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@Connor1996
address comment
e567530 
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
glorv
glorv approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@glorv glorv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Status: PR - There is already 1 approval label Jan 17, 2023
@ti-chi-bot
Copy link
Member

@BornChanger: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Jan 17, 2023
@tabokie
Copy link
Member

tabokie commented Jan 17, 2023

/merge

@ti-chi-bot
Copy link
Member

@tabokie: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 440fc0d

@ti-chi-bot ti-chi-bot added the status/can-merge Status: Can merge to base branch label Jan 17, 2023
@ti-chi-bot ti-chi-bot merged commit e2e9f9c into tikv:master Jan 17, 2023
@ti-chi-bot ti-chi-bot added this to the Pool milestone Jan 17, 2023
@Connor1996 Connor1996 deleted the sched-pool branch January 18, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glorv glorv glorv approved these changes

@tabokie tabokie tabokie approved these changes

@BornChanger BornChanger BornChanger approved these changes

Assignees
No one assigned
Labels
release-note size/XXL status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Milestone
Pool
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Connor1996 @ti-chi-bot @tabokie @glorv @BornChanger