Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: allow starting TiKV nodes with <1 CPU #14084

Merged
merged 1 commit into from Jan 29, 2023
Merged

config: allow starting TiKV nodes with <1 CPU #14084

merged 1 commit into from Jan 29, 2023

Conversation

andreid-db
Copy link
Contributor

What is changed and how it works?

Issue Number: Close #13586, Close #13752, Ref #14017

What's Changed: Allow starting TiKV nodes with <1 CPU.

Before this change even starting a TiKV node with 0.999 CPU would fail because of rounding.

Check List

Tests

  • Manual test: started on k8s with 0.3 CPU
Bug fix: Allow starting TiKV nodes with <1 CPU

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 26, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv
  • tabokie

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

Welcome @andreid-db!

It looks like this is your first PR to tikv/tikv 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to tikv/tikv. 😃

@andreid-db
Allow starting TiKV nodes with <1 CPU.
9d150c9 
Allow starting TiKV nodes with <1 CPU.

Before this change even starting a TiKV node with 0.999 CPU would fail because of rounding.

Signed-off-by: Andrei Dragus <andrei.dragus@databricks.com>
@andreid-db
Copy link
Contributor Author

/retest

@andreid-db
Copy link
Contributor Author

/test all

@andreid-db
Copy link
Contributor Author

/cc glorv

@ti-chi-bot ti-chi-bot requested a review from glorv January 26, 2023 03:55
@andreid-db
Copy link
Contributor Author

/cc nrc

@ti-chi-bot ti-chi-bot requested a review from nrc January 26, 2023 03:59
@ti-chi-bot ti-chi-bot added the status/LGT1 Status: PR - There is already 1 approval label Jan 28, 2023
glorv
glorv approved these changes Jan 28, 2023
View reviewed changes
Copy link
Contributor

@glorv glorv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Jan 28, 2023
@tabokie
Copy link
Member

tabokie commented Jan 29, 2023

/merge

@ti-chi-bot
Copy link
Member

@tabokie: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@tabokie tabokie changed the title config: Allow starting TiKV nodes with <1 CPU config: allow starting TiKV nodes with <1 CPU Jan 29, 2023
@tabokie
Copy link
Member

tabokie commented Jan 29, 2023

/check-issue-triage-complete

@tabokie
Copy link
Member

tabokie commented Jan 29, 2023

/merge

@ti-chi-bot
Copy link
Member

@tabokie: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@tabokie tabokie added the status/can-merge Status: Can merge to base branch label Jan 29, 2023
@ti-chi-bot ti-chi-bot removed the status/can-merge Status: Can merge to base branch label Jan 29, 2023
@tabokie
Copy link
Member

tabokie commented Jan 29, 2023

/merge

@ti-chi-bot
Copy link
Member

@tabokie: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9d150c9

@ti-chi-bot ti-chi-bot added the status/can-merge Status: Can merge to base branch label Jan 29, 2023
@ti-chi-bot ti-chi-bot merged commit c353910 into tikv:master Jan 29, 2023
@ti-chi-bot ti-chi-bot added this to the Pool milestone Jan 29, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 29, 2023
Open
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #14089.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 29, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #14090.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 29, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #14091.

@jebter jebter removed needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 needs-cherry-pick-release-6.1 labels Feb 7, 2023
ti-chi-bot added a commit that referenced this pull request Feb 15, 2023
@ti-chi-bot @andreid-db @tabokie
config: allow starting TiKV nodes with <1 CPU (#14084) (#14091)
5cdc134 
close #13586, close #13752, ref #14017, ref #14084

Signed-off-by: Andrei Dragus <andrei.dragus@databricks.com>

Co-authored-by: Andrei Dragus <andrei.dragus@databricks.com>
Co-authored-by: Xinye Tao <xy.tao@outlook.com>
ti-chi-bot added a commit that referenced this pull request Mar 27, 2023
@ti-chi-bot @andreid-db
config: allow starting TiKV nodes with <1 CPU (#14084) (#14090)
339ec83 
close #13586, close #13752, ref #14017, ref #14084

Signed-off-by: Andrei Dragus <andrei.dragus@databricks.com>

Co-authored-by: Andrei Dragus <andrei.dragus@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glorv glorv glorv approved these changes

@tabokie tabokie tabokie approved these changes

@nrc nrc Awaiting requested review from nrc

Assignees
No one assigned
Labels
contribution Type: PR - From contributors first-time-contributor needs-cherry-pick-release-6.5 release-note size/XS status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Milestone
Pool
5 participants
@andreid-db @ti-chi-bot @tabokie @glorv @jebter