Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raftstore-v2: add tablet logger and update dep #14129

Merged
merged 2 commits into from Feb 3, 2023

Conversation

BusyJay
Copy link
Member

@BusyJay BusyJay commented Feb 2, 2023

What is changed and how it works?

Issue Number: Ref #12842

What's Changed:

- Update raft-engine to fix data corruption during restart
- Add tablet logger so we can know which tablet the logs belongs to

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Breaking backward compatibility
    If a cluster is upgraded to this version, downgrade it may leave garbage in raft engine.

Release note

None

- Update raft-engine to fix data corruption during restart
- Add tablet logger so we can know which tablet the logs belongs to

Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@BusyJay BusyJay requested a review from tabokie February 2, 2023 10:58
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 2, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tabokie
  • tonyxuqqi

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@ti-chi-bot ti-chi-bot added size/XL and removed size/L labels Feb 2, 2023
@BusyJay
Copy link
Member Author

BusyJay commented Feb 2, 2023

Logs look like following:

[2023/02/02 19:15:16.720 +08:00][5][INFO] [251_1378234][db/flush_job.cc:828] [lock] [JOB 9] Flushing memtable with next log file: 2003
[2023/02/02 19:15:16.720 +08:00][5][INFO] [251_1378234]EVENT_LOG_v1 {"time_micros": 1675336516720097, "job": 9, "event": "flush_started", "num_memtables": 1, "num_entries": 4027359, "num_deletes": 2043131, "total_data_size": 549341116, "memory_usage": 668814856, "flush_reason": "Get Live Files"}
[2023/02/02 19:15:16.720 +08:00][5][INFO] [251_1378234][db/flush_job.cc:857] [lock] [JOB 9] Level-0 flush table #2458: started

"251_1378234" is the tablet name.

Copy link
Contributor

@bufferflies bufferflies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Status: PR - There is already 1 approval label Feb 3, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Feb 3, 2023
@BusyJay
Copy link
Member Author

BusyJay commented Feb 3, 2023

/merge

@ti-chi-bot
Copy link
Member

@BusyJay: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: cde8de3

@ti-chi-bot ti-chi-bot added the status/can-merge Status: Can merge to base branch label Feb 3, 2023
@ti-chi-bot ti-chi-bot merged commit 3791560 into tikv:master Feb 3, 2023
@ti-chi-bot ti-chi-bot added this to the Pool milestone Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/XL status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants