Raftstore-v2: support split operator #14199
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
do-not-merge/needs-linked-issue
release-note
contribution
|
/test |
| @@ -305,6 +305,10 @@ impl<'a, EK: KvEngine, ER: RaftEngine, T: Transport> PeerFsmDelegate<'a, EK, ER, | |||
| .peer_mut() | |||
| .on_request_split(self.store_ctx, request, ch) | |||
| } | |||
| PeerMsg::RequestHalfSplit { request, ch } => self | |||
There was a problem hiding this comment.
It seems it's used by test purpose only. It would be better to make it test only.
There was a problem hiding this comment.
I guess it's not for test purpose. The request is lanuched by pd-ctl.
| @@ -149,6 +149,15 @@ pub struct RequestSplit { | |||
| pub source: Cow<'static, str>, | |||
| } | |||
|
|
|||
| #[derive(Debug)] | |||
| pub struct RequestHalfSplit { | |||
There was a problem hiding this comment.
If it's test only, it would be better to make it test only. Check other example for test-only structures (search testexport)
|
/test |
ti-chi-bot
added
status/LGT2
|
/merge |
|
@tabokie: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 37a33fd
|
Signed-off-by: SpadeA-Tang u6748471@anu.edu.au
What is changed and how it works?
Issue Number: Ref #12842
What's Changed:
Check List
Tests
Release note