Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raftstore-v2: store heartbeat supports write keys and bytes. #14271

Merged
merged 4 commits into from Mar 2, 2023

Conversation

bufferflies
Copy link
Contributor

@bufferflies bufferflies commented Feb 23, 2023

What is changed and how it works?

Issue Number: Ref #12842

What's Changed:

1. store heartbeat supports write keys and bytes.

Related changes

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)

image

Side effects

Release note

None.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 23, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • BusyJay
  • tonyxuqqi

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: bufferflies <1045931706@qq.com>
@bufferflies
Copy link
Contributor Author

/cc @tonyxuqqi @tabokie @BusyJay

@ti-chi-bot ti-chi-bot added status/LGT1 Status: PR - There is already 1 approval needs-rebase labels Mar 1, 2023
@bufferflies
Copy link
Contributor Author

/ping @BusyJay @tabokie

Signed-off-by: bufferflies <1045931706@qq.com>
Signed-off-by: bufferflies <1045931706@qq.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Mar 2, 2023
@BusyJay
Copy link
Member

BusyJay commented Mar 2, 2023

/merge

@ti-chi-bot
Copy link
Member

@BusyJay: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b501db1

@ti-chi-bot ti-chi-bot added status/can-merge Status: Can merge to base branch and removed do-not-merge/needs-linked-issue labels Mar 2, 2023
@ti-chi-bot ti-chi-bot merged commit d74fd13 into tikv:master Mar 2, 2023
@ti-chi-bot ti-chi-bot added this to the Pool milestone Mar 2, 2023
@nolouch nolouch deleted the write_keys branch March 3, 2023 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/M status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants