New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sst_importer: add wire extra bytes into the packed size #14312
Conversation
Signed-off-by: hillium <yujuncen@pingcap.com>
Signed-off-by: hillium <yujuncen@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: hillium <yujuncen@pingcap.com>
…/tikv into try-fix-entry-too-large
Better add a test. |
Signed-off-by: hillium <yujuncen@pingcap.com>
Maybe we should let the engine to tell the size of modification. In raftkv2, writes are encoded using more simple codec and can batch up more modifications than v1. |
@BusyJay I agree the idea of letting the engine provide some way to calculate "real size" of some write, and I think before we figuring out some ideal interface definition, perhaps we can merge this for solving the problem we have encountered now? |
LGTM |
/merge |
@tabokie: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 7385494
|
close tikv#14313 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
close tikv#14313 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What is changed and how it works?
Issue Number: Close #14313
What's Changed:
This PR added some extra bytes for each modification, so the
unpacked_size
would be nearer to the real raft entry size.Check List
Tests
I have tested it in the internal cluster, if you are a PingCAP employee, you can check it at here. There aren't suitable screenshots to be published, sorry for that.
And I guess this can also be checked by any table with average row size less than 70B (see the comments), but for now I don't have suitable cluster for running such tests...
Release note
(This is a fix over the master branch.)