New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raftstore-v2: reduce file count #14318

Merged

ti-chi-bot merged 7 commits into tikv:master from BusyJay:fix-tablet-race

Mar 2, 2023

Member

BusyJay commented Mar 1, 2023 •

edited

What is changed and how it works?

Issue Number: Close #14316
Close #14306
Close #14324

What's Changed:

Compaction guard is disabled in v2, which will use 8MiB for file size. We need
set multiplier to reduce sst file count.

This PR also fixes a race between region creation and destroy.

Check List

Tests

Unit test
Integration test

Release note

None


          raftstore-v2: reduce file count

81448a2

Compaction guard is disabled in v2, which will use 8MiB for file size.
We need set multiplier to reduce sst file count.

Signed-off-by: Jay Lee <BusyJayLee@gmail.com>

BusyJay requested review from tonyxuqqi and tabokie

March 1, 2023 12:37

Member

ti-chi-bot commented Mar 1, 2023 •

edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

tabokie
tonyxuqqi

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot added do-not-merge/needs-triage-completed release-note-none size/S labels

Member Author

BusyJay commented Mar 1, 2023

/release

Contributor

sre-bot commented Mar 1, 2023

download tikv at http://fileserver.pingcap.net/download/builds/pingcap/tikv/pr/81448a2e992e28318eb9e6bd7669f649b7ab99d0/centos7/tikv-server.tar.gz


          clean up on drop

01f798c

Signed-off-by: Jay Lee <BusyJayLee@gmail.com>

ti-chi-bot added size/M and removed size/S labels

tabokie approved these changes

View reviewed changes

src/config/mod.rs Outdated

+                      } else {
+                          // If compaction guard is disabled, we need to set multiplier to reduce file
+                          // count.
+                          cf_opts.set_target_file_size_multiplier(2);

Member

tabokie Mar 1, 2023

This should be a v2 optimization instead of guard related. The multiplier has been 1 when guard isn't implemented before. We don't know how changing it to 2 will affect older clusters.

ti-chi-bot added the status/LGT1 label


          address comment

5d4f191

Signed-off-by: Jay Lee <BusyJayLee@gmail.com>

Member Author

BusyJay commented Mar 1, 2023

/release


          fix test

9bbea58

Signed-off-by: Jay Lee <BusyJayLee@gmail.com>

Member Author

BusyJay commented Mar 1, 2023

/release

Contributor

sre-bot commented Mar 1, 2023

download tikv at http://fileserver.pingcap.net/download/builds/pingcap/tikv/pr/9bbea5860e7eaf5da828a9717215b803fb090c06/centos7/tikv-server.tar.gz


          fix test

1189dbb

Signed-off-by: Jay Lee <BusyJayLee@gmail.com>

ti-chi-bot added size/L and removed do-not-merge/needs-triage-completed size/M labels

tonyxuqqi reviewed

View reviewed changes

components/raftstore-v2/src/fsm/peer.rs

+              impl<EK: KvEngine, ER: RaftEngine> Drop for PeerFsm<EK, ER> {
+                  fn drop(&mut self) {
+                      self.peer_mut().pending_reads_mut().clear_all(None);

Contributor

tonyxuqqi Mar 1, 2023

self.peer_mut().pending_reads_mut().clear_all(None);

Should it solve the "resource leak" panic found by QA?

tonyxuqqi approved these changes

View reviewed changes

ti-chi-bot added status/LGT2 and removed status/LGT1 labels


          ease apply scheduler check

2ae3430

Signed-off-by: Jay Lee <BusyJayLee@gmail.com>

Member Author

BusyJay commented Mar 2, 2023

/merge

Member

ti-chi-bot commented Mar 2, 2023

@BusyJay: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Member

ti-chi-bot commented Mar 2, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 2ae3430

ti-chi-bot added the status/can-merge label


          Merge branch 'master' into fix-tablet-race

0594e0b

Member

ti-chi-bot commented Mar 2, 2023

@BusyJay: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot merged commit 69dba51 into tikv:master

ti-chi-bot added this to the Pool milestone

BusyJay deleted the fix-tablet-race branch

March 2, 2023 05:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment