Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coprocessor: avoid fmsketch calculation for single-column index #14345

Merged
merged 4 commits into from Mar 6, 2023

Conversation

xuyifangreeneyes
Copy link
Contributor

What is changed and how it works?

Issue Number: ref #14231

What's Changed:

Implement pingcap/tidb#41931 in the tikv side. For the sinlge-column group, its fm_sketch is the same as that of the corresponding column. Hence, we don't maintain its fm_sketch in collect_column_group. We just copy the corresponding column's fm_sketch after iterating all rows. Also, we can directly copy total_size and null_count.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Side effects

Release note

None

Signed-off-by: xuyifan <675434007@qq.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 4, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Xuanwo
  • skyzh

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: xuyifan <675434007@qq.com>
@xuyifangreeneyes
Copy link
Contributor Author

/build

@xuyifangreeneyes
Copy link
Contributor Author

/run-build

@ti-chi-bot
Copy link
Member

@winoros: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@xuyifangreeneyes
Copy link
Contributor Author

/cc @skyzh @AndreMouche @Xuanwo

@ti-chi-bot ti-chi-bot added the status/LGT1 Status: PR - There is already 1 approval label Mar 6, 2023
Signed-off-by: xuyifan <675434007@qq.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Mar 6, 2023
@xuyifangreeneyes
Copy link
Contributor Author

@skyzh Could you help trigger merge? Thx~

@skyzh
Copy link
Member

skyzh commented Mar 6, 2023

/merge

@ti-chi-bot
Copy link
Member

@skyzh: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7aca843

@ti-chi-bot ti-chi-bot added the status/can-merge Status: Can merge to base branch label Mar 6, 2023
@ti-chi-bot
Copy link
Member

@xuyifangreeneyes: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 199e63f into tikv:master Mar 6, 2023
1 check passed
@ti-chi-bot ti-chi-bot added this to the Pool milestone Mar 6, 2023
@xuyifangreeneyes xuyifangreeneyes deleted the single-col-idx branch March 6, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution Type: PR - From contributors release-note-none size/M status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants