Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integration test v2: mvcc resolve lock gc test #14360

Merged
merged 7 commits into from Mar 9, 2023
Merged

integration test v2: mvcc resolve lock gc test #14360

merged 7 commits into from Mar 9, 2023

Conversation

SpadeA-Tang
Copy link
Member

@SpadeA-Tang SpadeA-Tang commented Mar 7, 2023 •
edited

What is changed and how it works?

Issue Number: Ref #12842

What's Changed:

mvcc resolve lock gc test for v2

This PR resuse test_mvcc_resolve_lock_gc_and_delete for raftstore-v2.
The PR also fixes a bug when reporting persisted/committed log duration which may cause panic:

  • It may miss updating metrics of the porposal with index to, making relevant metrics of the proposal unintialized. Later in write_write_detail, it will panic due to 0 - a posive number.

Tests

  • Unit test
  • Integration test

Release note 

None

@SpadeA-Tang
init
e914bc8 
Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au>
@SpadeA-Tang
update
15d1e09 
Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 7, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tabokie
  • tonyxuqqi

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none contribution Type: PR - From contributors size/S labels Mar 7, 2023
bufferflies
bufferflies reviewed Mar 7, 2023
View reviewed changes
components/raftstore-v2/src/operation/ready/mod.rs Outdated
@@ -680,7 +680,7 @@ impl<EK: KvEngine, ER: RaftEngine> Peer<EK, ER> {
return;
}
let now = Instant::now();
for i in from + 1..to {
for i in from + 1..=to {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it belongs the type/bug, you should add some comment on the pr.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

bufferflies
bufferflies reviewed Mar 7, 2023
View reviewed changes
components/test_raftstore-v2/src/server.rs Outdated
@@ -634,6 +636,11 @@ impl ServerCluster {
Ok(node_id)
}

/// To trigger GC manually.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the useless comment.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ti-chi-bot
Copy link
Member

@bufferflies: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Status: PR - There is already 1 approval label Mar 7, 2023
@SpadeA-Tang
Copy link
Member Author

/cc @tabokie PTAL

@ti-chi-bot ti-chi-bot requested a review from tabokie March 8, 2023 08:57
@ti-chi-bot
Copy link
Member

@SpadeA-Tang: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @tabokie PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tabokie
tabokie approved these changes Mar 8, 2023
View reviewed changes
components/raftstore-v2/src/operation/ready/mod.rs
@@ -680,7 +680,7 @@ impl<EK: KvEngine, ER: RaftEngine> Peer<EK, ER> {
return;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the argument name (from, to) to (old_index, new_index).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ti-chi-bot ti-chi-bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Mar 8, 2023
@SpadeA-Tang
address comment
22f053e 
Signed-off-by: Spade A <u6748471@anu.edu.au>
@ti-chi-bot ti-chi-bot added size/M and removed size/S labels Mar 8, 2023
@tabokie
Copy link
Member

tabokie commented Mar 8, 2023

/merge

@ti-chi-bot
Copy link
Member

@tabokie: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 75c5d42

@ti-chi-bot ti-chi-bot added the status/can-merge Status: Can merge to base branch label Mar 8, 2023
@ti-chi-bot ti-chi-bot merged commit 82ac84b into tikv:master Mar 9, 2023
@ti-chi-bot ti-chi-bot added this to the Pool milestone Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyxuqqi tonyxuqqi tonyxuqqi approved these changes

@bufferflies bufferflies bufferflies approved these changes

@tabokie tabokie tabokie approved these changes

Assignees
No one assigned
Labels
contribution Type: PR - From contributors release-note-none size/M status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Milestone
Pool
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SpadeA-Tang @ti-chi-bot @tabokie @tonyxuqqi @bufferflies