pitr: support modifying the config tikv.log-backup.max-flush-interval online.

[joccau]

What is changed and how it works?

Issue Number: Close #14433

What's Changed:
As title~

Related changes

• PR to update pingcap/docs/pingcap/docs-cn:
• Need to cherry-pick to the release branch

Check List

Tests

• - Unit test
• - Integration test
• - Manual test (add detailed scripts or steps below)
• - No code

Manual test

MySQL [(none)]> show config where type='tikv' and name='log-backup.max-flush-interval';
+------+-----------------+-------------------------------+-------+
| Type | Instance        | Name                          | Value |
+------+-----------------+-------------------------------+-------+
| tikv | 10.2.5.31:20162 | log-backup.max-flush-interval | 3m    |
| tikv | 10.2.5.11:20160 | log-backup.max-flush-interval | 3m    |
| tikv | 10.2.5.18:20161 | log-backup.max-flush-interval | 3m    |
+------+-----------------+-------------------------------+-------+


MySQL [(none)]> set config tikv `log-backup.max-flush-interval`="2m";
MySQL [(none)]> show config where type='tikv' and name='log-backup.max-flush-interval';
+------+-----------------+-------------------------------+-------+
| Type | Instance        | Name                          | Value |
+------+-----------------+-------------------------------+-------+
| tikv | 10.2.5.31:20162 | log-backup.max-flush-interval | 2m    |
| tikv | 10.2.5.11:20160 | log-backup.max-flush-interval | 2m    |
| tikv | 10.2.5.18:20161 | log-backup.max-flush-interval | 2m    |
+------+-----------------+-------------------------------+-------+

MySQL [(none)]> set config tikv `log-backup.max-flush-interval`="1m";
MySQL [(none)]> show config where type='tikv' and name='log-backup.max-flush-interval';
+------+-----------------+-------------------------------+-------+
| Type | Instance        | Name                          | Value |
+------+-----------------+-------------------------------+-------+
| tikv | 10.2.5.31:20162 | log-backup.max-flush-interval | 1m    |
| tikv | 10.2.5.11:20160 | log-backup.max-flush-interval | 1m    |
| tikv | 10.2.5.18:20161 | log-backup.max-flush-interval | 1m    |
+------+-----------------+-------------------------------+-------+

MySQL [(none)]> set config tikv `log-backup.max-flush-interval`="0m";
Query OK, 0 rows affected, 3 warnings (0.02 sec)

MySQL [(none)]> show warnings;
+---------+------+---------------------------------------------------------------------------------------------------------------------------------------------------------+
| Level   | Code | Message                                                                                                                                                 |
+---------+------+---------------------------------------------------------------------------------------------------------------------------------------------------------+
| Warning | 1105 | bad request to http://10.2.5.31:20182/config: failed to update, error: "the max_flush_interval is too small, it is 0s, and should be greater than 10s." |
| Warning | 1105 | bad request to http://10.2.5.11:20180/config: failed to update, error: "the max_flush_interval is too small, it is 0s, and should be greater than 10s." |
| Warning | 1105 | bad request to http://10.2.5.18:20181/config: failed to update, error: "the max_flush_interval is too small, it is 0s, and should be greater than 10s." |
+---------+------+---------------------------------------------------------------------------------------------------------------------------------------------------------+

Find message from tikv.log

[2023/03/20 19:21:33.708 +08:00] [INFO] [config.rs:29] [" log backup config changed"] [change="{\"max_flush_interval\": 120000ms}"]
[2023/03/20 19:29:02.639 +08:00] [INFO] [config.rs:29] [" log backup config changed"] [change="{\"max_flush_interval\": 60000ms}"]

Side effects

• Performance regression
  • Consumes more CPU
  • Consumes more MEM
• Breaking backward compatibility

Release note

PITR supports modifying the config tikv.log-backup.max-flush-interval online.

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• YuJuncen
• tonyxuqqi

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[YuJuncen]

generally lgtm

[ti-chi-bot]

@Leavrth: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[tonyxuqqi]

/merge

[ti-chi-bot]

@tonyxuqqi: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

@tonyxuqqi: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[tonyxuqqi]

/merge

[ti-chi-bot]

@tonyxuqqi: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: a7d1fcb

[joccau]

/retest

[joccau]

/rebuild