raftstore-v2: schedule raft tick after apply snapshot #14550
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
tests/failpoints/cases/test_snap.rs
Outdated
| @@ -900,3 +900,36 @@ fn test_snapshot_recover_from_raft_write_failure_with_uncommitted_log() { | |||
| cluster.must_put(format!("k1{}", i).as_bytes(), b"v1"); | |||
| } | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_issue_14548() { | |||
There was a problem hiding this comment.
Maybe you should rename it and add the issue linked this the test function?
There was a problem hiding this comment.
Any suggestions for the name of the test?
There was a problem hiding this comment.
I think it's better to rename the test with the test function.
In this case, maybe test_write_after_network_partition
| apply_state.set_applied_index(5); | ||
| }); | ||
| }; | ||
| reset_apply_index(); |
There was a problem hiding this comment.
why not calling
fail_point!("RESET_APPLY_INDEX_WHEN_RESTART", |_| {
apply_state.set_applied_index(5);
});
directly?
There was a problem hiding this comment.
The failpoint will return.
ti-chi-bot
added
status/LGT2
Signed-off-by: Spade A <u6748471@anu.edu.au>
|
/merge |
|
@tonyxuqqi: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 58b74ae
|
What is changed and how it works?
Issue Number: Close #14548, #14532
What's Changed:
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Release note