Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txn: round up last_update_duration_ms #14571

Merged
merged 9 commits into from Apr 18, 2023

Conversation

ekexium
Copy link
Contributor

@ekexium ekexium commented Apr 14, 2023

What is changed and how it works?

Issue Number: ref #14497

What's Changed:

Round up last_update_duration_ms, so that duration in (0, 1ms] won't be treated as 0.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

Release note

None

Signed-off-by: ekexium <eke@fastmail.com>
Signed-off-by: ekexium <eke@fastmail.com>
This reverts commit cb8e741.

Signed-off-by: ekexium <eke@fastmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 14, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • MyonKeminta
  • cfzjywxk

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ekexium
Copy link
Contributor Author

ekexium commented Apr 14, 2023

/test

src/server/lock_manager/waiter_manager.rs Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Status: PR - There is already 1 approval label Apr 14, 2023
Signed-off-by: ekexium <eke@fastmail.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Apr 17, 2023
@cfzjywxk
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

@cfzjywxk: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7b9edff

@ti-chi-bot ti-chi-bot added the status/can-merge Status: Can merge to base branch label Apr 17, 2023
@MyonKeminta
Copy link
Contributor

/test

@ti-chi-bot
Copy link
Member

@ekexium: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 0c113a6 into tikv:master Apr 18, 2023
7 checks passed
@ti-chi-bot ti-chi-bot added this to the Pool milestone Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/XS status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants