Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raft: peers shouldn't hibernate incorrectly when one node fails (#14574) #14632

Merged
merged 3 commits into from May 31, 2023
Merged

raft: peers shouldn't hibernate incorrectly when one node fails (#14574) #14632

merged 3 commits into from May 31, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #14574

What is changed and how it works?

Issue Number: Ref #14547

What's Changed:

raft: peers shouldn't hibernate incorrectly when one node fails

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Integration test

Side effects

Release note 

None

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Apr 21, 2023 •
edited by ti-chi-bot bot

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Connor1996
  • hicqu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 21, 2023
Merged
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Apr 27, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Apr 27, 2023
@hicqu
Copy link
Contributor

hicqu commented May 15, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 15, 2023

@hicqu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 15, 2023

@hicqu: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hicqu
Copy link
Contributor

hicqu commented May 15, 2023

/test

@hicqu
Copy link
Contributor

hicqu commented May 23, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 23, 2023

@hicqu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 23, 2023

@hicqu: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hicqu @ti-chi-bot
raft: peers shouldn't hibernate incorrectly when one node fails (tikv…
9b367b2 
…#14574)

Signed-off-by: qupeng <qupeng@pingcap.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
@hicqu hicqu force-pushed the cherry-pick-14574-to-release-6.5 branch from b4e6c97 to 9b367b2 Compare May 23, 2023 08:33
@ti-chi-bot ti-chi-bot bot added size/XL and removed size/XXL labels May 23, 2023
@hicqu
Copy link
Contributor

hicqu commented May 23, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 23, 2023

@hicqu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 23, 2023

@hicqu: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Status: PR - There is already 1 approval label May 24, 2023
Connor1996
Connor1996 approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels May 24, 2023
@Ivy-YinSu
Copy link

/run-all-tests

@hicqu
Copy link
Contributor

hicqu commented May 31, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 31, 2023

@hicqu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 31, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 377bd6f

@ti-chi-bot ti-chi-bot bot added the status/can-merge Status: Can merge to base branch label May 31, 2023
@ti-chi-bot ti-chi-bot bot merged commit d699444 into tikv:release-6.5 May 31, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hicqu hicqu hicqu approved these changes

@Connor1996 Connor1996 Connor1996 approved these changes

Assignees

@hicqu hicqu

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none size/XL status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals type/cherry-pick-for-release-6.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ti-chi-bot @hicqu @Ivy-YinSu @Connor1996 @VelocityLight