Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raftstore-v2: check locks on step read index #14736

Merged
merged 4 commits into from May 16, 2023
Merged

raftstore-v2: check locks on step read index #14736

merged 4 commits into from May 16, 2023

Conversation

overvenus
Copy link
Member

What is changed and how it works?

Issue Number: ref #14701

What's Changed:

raftstore-v2: check locks on step read index

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Release note 

None

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 11, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SpadeA-Tang
  • tonyxuqqi

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@overvenus
raftstore-v2: check locks on step read index
47c4e04 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus
enable failpoints tests
434f12a 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus overvenus force-pushed the raftstorev2/read-index-check-lock branch from 3c2e62b to 434f12a Compare May 12, 2023 09:14
@overvenus
enable more tests
1926c6a 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus
Merge branch 'master' into raftstorev2/read-index-check-lock
d0a1ed9 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@ti-chi-bot ti-chi-bot bot removed the needs-rebase label May 15, 2023
@overvenus overvenus marked this pull request as ready for review May 15, 2023 11:42
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Status: PR - There is already 1 approval label May 15, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels May 16, 2023
@overvenus
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 16, 2023

@overvenus: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 16, 2023

This pull request has been accepted and is ready to merge.

Commit hash: d0a1ed9

@ti-chi-bot ti-chi-bot bot added the status/can-merge Status: Can merge to base branch label May 16, 2023
@overvenus
Copy link
Member Author

/test

5 similar comments
@overvenus
Copy link
Member Author

/test

@purelind
Copy link
Collaborator

/test

@purelind
Copy link
Collaborator

/test

@purelind
Copy link
Collaborator

/test

@purelind
Copy link
Collaborator

/test

@ti-chi-bot ti-chi-bot bot merged commit 523ff95 into tikv:master May 16, 2023
7 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone May 16, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request May 16, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #14758.

ti-chi-bot bot added a commit that referenced this pull request May 17, 2023
@ti-chi-bot @overvenus @ti-chi-bot
raftstore-v2: check locks on step read index (#14736) (#14758)
abd7fe0 
ref #14701, ref #14736

raftstore-v2: check locks on step read index

Signed-off-by: Neil Shen <overvenus@gmail.com>

Co-authored-by: Neil Shen <overvenus@gmail.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyxuqqi tonyxuqqi tonyxuqqi approved these changes

@SpadeA-Tang SpadeA-Tang SpadeA-Tang approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-7.1 release-note-none size/XXL status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Milestone
Pool
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@overvenus @purelind @ti-chi-bot @tonyxuqqi @SpadeA-Tang