Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdc: support EventFeedV2 RPC and introduce stream multiplexing #14923

Merged
merged 2 commits into from Jul 5, 2023

Conversation

hicqu
Copy link
Contributor

@hicqu hicqu commented Jun 12, 2023

What is changed and how it works?

Issue Number: Close #14967 .

What's Changed:

  • TiCDCs send version and features headers to TiKVs when establishing a connection;
  • add a new TiCDC feature stream multiplexing;

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

Release note

None

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 12, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • hi-rustin

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@hicqu
Copy link
Contributor Author

hicqu commented Jun 15, 2023

/test

@hicqu hicqu changed the title cdc: support stream multiplexing cdc: support EventFeedV2 RPC and introduce stream multiplexing Jun 19, 2023
@hicqu
Copy link
Contributor Author

hicqu commented Jun 19, 2023

/test

components/cdc/src/endpoint.rs Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Status: PR - There is already 1 approval label Jun 20, 2023
components/cdc/src/endpoint.rs Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Jul 4, 2023
@hicqu
Copy link
Contributor Author

hicqu commented Jul 4, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 4, 2023

@hicqu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 4, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 9703fc7

@ti-chi-bot ti-chi-bot bot added the status/can-merge Status: Can merge to base branch label Jul 4, 2023
Signed-off-by: qupeng <qupeng@pingcap.com>
@ti-chi-bot ti-chi-bot bot removed the status/can-merge Status: Can merge to base branch label Jul 4, 2023
@hicqu
Copy link
Contributor Author

hicqu commented Jul 4, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 4, 2023

@hicqu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 4, 2023

This pull request has been accepted and is ready to merge.

Commit hash: d7a5672

@ti-chi-bot ti-chi-bot bot added the status/can-merge Status: Can merge to base branch label Jul 4, 2023
@ti-chi-bot ti-chi-bot bot merged commit 337582c into tikv:master Jul 5, 2023
7 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Jul 5, 2023
@hicqu hicqu deleted the cdc-reuse-conn branch July 5, 2023 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/XXL status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CDC clients send version and requested features to TiKV when establishing a connection
5 participants