New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raftstore-v2: fix delete range #15019
Conversation
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: tabokie <xy.tao@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
"duration" => ?start.saturating_elapsed(), | ||
); | ||
|
||
if index != u64::MAX && written { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When is it u64::MAX
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know, it's the old code, shared by all write requests.
@@ -92,7 +92,7 @@ fn test_delete() { | |||
} | |||
|
|||
#[test_case(test_raftstore::new_node_cluster)] | |||
#[test_case(test_raftstore_v2::new_node_cluster)] | |||
// v2 doesn't support. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it rocksdb delete range or RaftCmd::DeleteRange? Could you add some comments?
components/engine_rocks/src/misc.rs
Outdated
@@ -39,7 +42,8 @@ impl RocksEngine { | |||
.as_ref() | |||
.map_or(false, |key| key.as_slice() > r.start_key) | |||
{ | |||
self.delete_all_in_range_cf_by_key(cf, &r)?; | |||
self.delete_all_in_range_cf_by_key(wopts, cf, &r)?; | |||
written = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
written |= self.delete_all_in_range_cf_by_key(wopts, cf, &r)?;
Signed-off-by: tabokie <xy.tao@outlook.com>
dedc836
to
6280fc3
Compare
/merge |
@tabokie: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 79f3d38
|
Signed-off-by: tabokie <xy.tao@outlook.com>
/merge |
@tabokie: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: dc7719a
|
/run-test retry=5 |
In response to a cherrypick label: new pull request created to branch |
ref tikv#12842 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What is changed and how it works?
Issue Number: Ref #12842
What's Changed:
Related changes
Check List
Tests
Release note