Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raftstore-v2: optimize the slowness detection on the Io-Hang scenario. #15071

Merged
merged 7 commits into from Jul 10, 2023

Conversation

LykxSassinator
Copy link
Contributor

@LykxSassinator LykxSassinator commented Jul 5, 2023

What is changed and how it works?

Issue Number: Ref #15070

What's Changed:

This pr includes:
* Polish the annotations in `raftstore-v2/src/worker/pd/slowness.rs`.
* Optimize the detection and the interval of reporting statistics on the io hang case.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

None.

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 5, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • innerr
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added contribution Type: PR - From contributors size/M labels Jul 5, 2023
@LykxSassinator
Copy link
Contributor Author

/cc @tonyxuqqi @innerr

@ti-chi-bot ti-chi-bot bot requested review from innerr and tonyxuqqi July 6, 2023 04:12
@LykxSassinator LykxSassinator changed the title raftstore-v2: optimize the slowness detection on the Io-Hang scenario. [Dynamic Region] raftstore-v2: optimize the slowness detection on the Io-Hang scenario. Jul 6, 2023
@LykxSassinator
Copy link
Contributor Author

/cc @overvenus

PTAL, thx

@ti-chi-bot ti-chi-bot bot requested a review from overvenus July 7, 2023 07:01
Copy link
Contributor

@innerr innerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Status: PR - There is already 1 approval label Jul 7, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Jul 10, 2023
@overvenus overvenus changed the title [Dynamic Region] raftstore-v2: optimize the slowness detection on the Io-Hang scenario. raftstore-v2: optimize the slowness detection on the Io-Hang scenario. Jul 10, 2023
@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 10, 2023

@overvenus: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 10, 2023

This pull request has been accepted and is ready to merge.

Commit hash: b258b22

@ti-chi-bot ti-chi-bot bot added the status/can-merge Status: Can merge to base branch label Jul 10, 2023
@ti-chi-bot ti-chi-bot bot merged commit 20afd17 into tikv:master Jul 10, 2023
6 of 7 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution Type: PR - From contributors release-note-none size/M status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants