New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raftstore: use future pool for snap-generator pool #15079
Conversation
Signed-off-by: nolouch <nolouch@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/test |
@@ -887,10 +894,6 @@ where | |||
} | |||
} | |||
} | |||
|
|||
fn shutdown(&mut self) { | |||
self.pool.shutdown(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you needs to impl it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think no place to use the shutdown current.
/test |
ptal @overvenus |
@@ -858,7 +860,12 @@ where | |||
for_balance, | |||
allow_multi_files_snapshot, | |||
); | |||
}); | |||
}).unwrap_or_else( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we need notify raftstore that snapshot will not be generated. Otherwise, leader will not retry generate snapshot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think once the notifier
is dropped(after failing), the generator can be retried.
tikv/components/raftstore/src/store/peer_storage.rs
Lines 513 to 524 in 189e4c4
Err(TryRecvError::Disconnected) | Ok(_) => { | |
*snap_state = SnapState::Relax; | |
warn!( | |
"failed to try generating snapshot"; | |
"region_id" => self.region.get_id(), | |
"peer_id" => self.peer_id, | |
"times" => *tried_cnt, | |
"request_peer" => to, | |
); | |
} | |
} | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
@pingyu: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 728ca9b
|
/test |
@nolouch: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/test |
1 similar comment
/test |
What is changed and how it works?
Issue Number: Close #14940
What's Changed:
Fix miss snap-generator pool metrics.
Check List
Tests
Before:
After:
Release note