Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raftstore: use future pool for snap-generator pool #15079

Merged
merged 7 commits into from Jul 10, 2023

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Jul 6, 2023

What is changed and how it works?

Issue Number: Close #14940

What's Changed:
Fix miss snap-generator pool metrics.

raftstore: use future pool for snap-generator pool

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)

Before:
image

After:
image

Release note

None

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 6, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SpadeA-Tang
  • bufferflies

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Status: PR - There is already 1 approval label Jul 6, 2023
@nolouch
Copy link
Contributor Author

nolouch commented Jul 6, 2023

/test

@@ -887,10 +894,6 @@ where
}
}
}

fn shutdown(&mut self) {
self.pool.shutdown();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you needs to impl it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think no place to use the shutdown current.

@ti-chi-bot ti-chi-bot bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Jul 6, 2023
@nolouch
Copy link
Contributor Author

nolouch commented Jul 6, 2023

/test

@nolouch
Copy link
Contributor Author

nolouch commented Jul 7, 2023

ptal @overvenus

@@ -858,7 +860,12 @@ where
for_balance,
allow_multi_files_snapshot,
);
});
}).unwrap_or_else(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we need notify raftstore that snapshot will not be generated. Otherwise, leader will not retry generate snapshot.

Copy link
Contributor Author

@nolouch nolouch Jul 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think once the notifier is dropped(after failing), the generator can be retried.

Err(TryRecvError::Disconnected) | Ok(_) => {
*snap_state = SnapState::Relax;
warn!(
"failed to try generating snapshot";
"region_id" => self.region.get_id(),
"peer_id" => self.peer_id,
"times" => *tried_cnt,
"request_peer" => to,
);
}
}
}

Copy link
Member

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pingyu
Copy link
Contributor

pingyu commented Jul 10, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 10, 2023

@pingyu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 10, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 728ca9b

@ti-chi-bot ti-chi-bot bot added the status/can-merge Status: Can merge to base branch label Jul 10, 2023
@nolouch
Copy link
Contributor Author

nolouch commented Jul 10, 2023

/test

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 10, 2023

@nolouch: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@nolouch
Copy link
Contributor Author

nolouch commented Jul 10, 2023

/test

1 similar comment
@nolouch
Copy link
Contributor Author

nolouch commented Jul 10, 2023

/test

@ti-chi-bot ti-chi-bot bot merged commit 4c7b045 into tikv:master Jul 10, 2023
7 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Jul 10, 2023
@nolouch nolouch deleted the use-yatp-builder branch July 10, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/S status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add snapshot generation wait time metric
6 participants