encryption: fix key collision issue in tablet snapshot #15098
Conversation
Signed-off-by: tabokie <xy.tao@outlook.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
src/server/tablet_snap.rs
Outdated
| fs::remove_file(entry.path())?; | ||
| if let Some(m) = key_manager { | ||
| m.delete_file(entry.path().to_str().unwrap())?; | ||
| } |
There was a problem hiding this comment.
Is there any EncryptedFilesystem? Maybe we can wrap these two remove-file in EncryptedFilesystem::remove_file?
There was a problem hiding this comment.
Maybe in another PR, file_system is a drop-in replacement for std::fs, but remove_encrypted_file requires additional parameter, and it can't be placed in file_system crate due to cyclic dependency.
ti-chi-bot
bot
added
status/LGT2
|
/merge |
|
@tonyxuqqi: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: d7e574e
|
|
/merge |
|
@tabokie: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 9adf331
|
What is changed and how it works?
Issue Number: Close #15059
What's Changed:
Related changes
Check List
Tests
Release note