New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raftstore: allow DrAutoSync to majority commit log during SyncRecover phase (#15103) #15130
raftstore: allow DrAutoSync to majority commit log during SyncRecover phase (#15103) #15130
Conversation
close tikv#14975 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: nolouch <nolouch@gmail.com>
/cherry-pick-invite |
@nolouch Please accept the invitation then you can push to the cherry-pick pull requests. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test |
/merge |
@Connor1996: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 8fbd54c
|
This is an automated cherry-pick of #15103
What is changed and how it works?
Issue Number: Close #14975
What's Changed:
After this change, the
SyncRecover
phase will not enable group commits at first, once thedr replicas
catch up the logs, then enable the group commits. the region will report asINTEGRITY_OVER_LABEL
after catching up on the logs, after all, region is in theINTEGRITY_OVER_LABEL
state, PD will switch the stateSyncRecover
topSync
state.Check List
Tests