Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raftstore: allow DrAutoSync to majority commit log during SyncRecover phase (#15103) #15130

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #15103

What is changed and how it works?

Issue Number: Close #14975

What's Changed:

raftstore: do not enable group commit when replication mode is SyncRecover
- during DR mode, the SyncRecover state should be committed in majority mode. otherwise, the qps may drop

After this change, the SyncRecover phase will not enable group commits at first, once the dr replicas catch up the logs, then enable the group commits. the region will report as INTEGRITY_OVER_LABEL after catching up on the logs, after all, region is in the INTEGRITY_OVER_LABEL state, PD will switch the state SyncRecover top Sync state.

Check List

Tests

  • Unit test
  • Integration test
fix the QPS drop to zero in dr SyncRecovery phase in DR mode

close tikv#14975

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 14, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Connor1996
  • v01dstar

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch
Copy link
Contributor

nolouch commented Jul 17, 2023

/cherry-pick-invite

@ti-chi-bot
Copy link
Member Author

@nolouch Please accept the invitation then you can push to the cherry-pick pull requests.
Comment with "/cherry-pick-invite" if the invitation is expired.
https://github.com/ti-chi-bot/tikv/invitations

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 17, 2023
@nolouch
Copy link
Contributor

nolouch commented Jul 17, 2023

/retest

Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Status: PR - There is already 1 approval label Jul 17, 2023
Copy link
Contributor

@v01dstar v01dstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Jul 17, 2023
@nolouch
Copy link
Contributor

nolouch commented Jul 18, 2023

/test

@Connor1996
Copy link
Member

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 18, 2023

@Connor1996: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 18, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 8fbd54c

@ti-chi-bot ti-chi-bot bot added the status/can-merge Status: Can merge to base branch label Jul 18, 2023
@ti-chi-bot ti-chi-bot bot merged commit 1c1eec4 into tikv:release-6.5 Jul 18, 2023
3 checks passed
@nolouch nolouch deleted the cherry-pick-15103-to-release-6.5 branch July 18, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note size/L status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals type/cherry-pick-for-release-6.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants